Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- wasm-publish
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
comm-query-creator.js filename doesn't match the class inside
web/database/types/module.js | ||
---|---|---|
10–19 | Can these be read only? | |
27 | In the docs it's only an array of functions. Should we stick to the typescript defs (and remove the singular function option)? | |
30 | Can we type as mixed? | |
32 | Shouldn't this be a singular function? |
Comment Actions
Same feedback as here... best to avoid class and interface if possible. Sometimes they are needed for inheritance reasons, but it doesn't look like it here