Page MenuHomePhabricator

[web] rework metadata tests to use CommQueryExecutor
ClosedPublic

Authored by kamil on Jul 19 2023, 6:55 AM.
Tags
None
Referenced Files
F2197585: D8555.id28830.diff
Fri, Jul 5, 3:21 PM
F2197129: D8555.id29003.diff
Fri, Jul 5, 2:19 PM
F2192055: D8555.diff
Thu, Jul 4, 6:44 PM
Unknown Object (File)
Wed, Jul 3, 4:29 AM
Unknown Object (File)
Tue, Jul 2, 11:14 AM
Unknown Object (File)
Mon, Jul 1, 1:23 AM
Unknown Object (File)
Mon, Jul 1, 1:23 AM
Unknown Object (File)
Mon, Jul 1, 1:23 AM
Subscribers

Details

Summary

Updates test to new module

Depends on D8554

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Branch
wasm-publish
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jul 19 2023, 9:05 AM
kamil added inline comments.
web/database/queries/metadata-queries.test.js
30

native getMetadata returns std::string always

This revision is now accepted and ready to land.Jul 21 2023, 6:20 AM
web/database/queries/metadata-queries.test.js
42

Shouldn't we clear this metadata after the test?

web/database/queries/metadata-queries.test.js
42

indeed, I think to make those tests valid we should delete the entire database after each test, I updated the whole stack to reflect this need

This revision was landed with ongoing or failed builds.Jul 27 2023, 5:40 AM
This revision was automatically updated to reflect the committed changes.