Page MenuHomePhabricator
Differential D8558

[web] rework database module tests to use CommQueryExecutor
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 7:00 AM.
Tags
None
Referenced Files
F2197307: D8558.id29125.diff
Fri, Jul 5, 2:40 PM
F2197055: D8558.id28833.diff
Fri, Jul 5, 2:10 PM
F2196579: D8558.id29001.diff
Fri, Jul 5, 1:00 PM
F2196525: D8558.id29121.diff
Fri, Jul 5, 12:55 PM
Unknown Object (File)
Wed, Jul 3, 3:56 AM
Unknown Object (File)
Mon, Jul 1, 1:23 AM
Unknown Object (File)
Mon, Jul 1, 1:23 AM
Unknown Object (File)
Mon, Jul 1, 1:23 AM
View All 91 Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM1bc7a2637aeb: [web] rework database module tests to use CommQueryExecutor
Summary

Updates test to new module

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Branch
wasm-publish
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 19 2023, 7:00 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 7:00 AM
kamil added a child revision: D8559: [web] implement functions to import/export database content.Jul 19 2023, 7:02 AM
Harbormaster completed remote builds in B21037: Diff 28833.Jul 19 2023, 7:46 AM
kamil published this revision for review.Jul 19 2023, 9:07 AM
kamil added inline comments.
web/database/sql-js.test.js
29

no longer needed

michal accepted this revision.Jul 21 2023, 6:24 AM
This revision is now accepted and ready to land.Jul 21 2023, 6:24 AM
kamil mentioned this in D8611: [web] implement function to clear database content.Jul 25 2023, 2:01 AM
kamil removed a child revision: D8559: [web] implement functions to import/export database content.Jul 25 2023, 2:03 AM
kamil updated this revision to Diff 29001.Jul 25 2023, 2:05 AM

add clearSensitiveData tests

kamil edited parent revisions, added: D8559: [web] implement functions to import/export database content; removed: D8557: [web] rework storage engine tests to use CommQueryExecutor.Jul 25 2023, 2:05 AM
kamil added a child revision: D8554: [web] rework report tests to use CommQueryExecutor.
kamil requested review of this revision.Jul 25 2023, 2:19 AM

added a new test so I would like to have another look from the reviewers

Harbormaster completed remote builds in B21168: Diff 29001.Jul 25 2023, 2:28 AM
michal accepted this revision.Jul 25 2023, 6:17 AM

Can we also check if the FILE_PATH contains no file (with module.FS.stat or sth)?

This revision is now accepted and ready to land.Jul 25 2023, 6:17 AM
kamil edited the summary of this revision. (Show Details)Jul 27 2023, 5:11 AM
kamil updated this revision to Diff 29121.Jul 27 2023, 5:11 AM
kamil edited the summary of this revision. (Show Details)

add module.FS.stat test

Harbormaster completed remote builds in B21271: Diff 29121.Jul 27 2023, 5:30 AM
Closed by commit rCOMM1bc7a2637aeb: [web] rework database module tests to use CommQueryExecutor (authored by kamil). · Explain WhyJul 27 2023, 5:39 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMM6bd9bba33bc9: [web] implement function to clear database content.
kamil added a commit: rCOMM1bc7a2637aeb: [web] rework database module tests to use CommQueryExecutor.

Revision Contents
Changeset List

PathSize
web/
database/
11 lines

Diff 28833

View Options

web/database/db-module.test.js

Loading...
View Options

web/database/sql-js.test.js

Loading...