Page MenuHomePhabricator
Differential D8558

[web] rework database module tests to use CommQueryExecutor
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 7:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 6:10 PM
Unknown Object (File)
Wed, Mar 12, 10:49 AM
Unknown Object (File)
Wed, Mar 12, 7:04 AM
Unknown Object (File)
Wed, Mar 12, 2:05 AM
Unknown Object (File)
Tue, Mar 11, 9:50 AM
Unknown Object (File)
Mar 4 2025, 7:48 PM
Unknown Object (File)
Mar 4 2025, 5:54 PM
Unknown Object (File)
Mar 4 2025, 5:54 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM1bc7a2637aeb: [web] rework database module tests to use CommQueryExecutor
Summary

Updates test to new module

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 19 2023, 7:00 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 7:00 AM
kamil added a child revision: D8559: [web] implement functions to import/export database content.Jul 19 2023, 7:02 AM
Harbormaster completed remote builds in B21037: Diff 28833.Jul 19 2023, 7:46 AM
kamil published this revision for review.Jul 19 2023, 9:07 AM
kamil added inline comments.
web/database/sql-js.test.js
29 ↗(On Diff #28833)

no longer needed

michal accepted this revision.Jul 21 2023, 6:24 AM
This revision is now accepted and ready to land.Jul 21 2023, 6:24 AM
kamil mentioned this in D8611: [web] implement function to clear database content.Jul 25 2023, 2:01 AM
kamil removed a child revision: D8559: [web] implement functions to import/export database content.Jul 25 2023, 2:03 AM
kamil updated this revision to Diff 29001.Jul 25 2023, 2:05 AM

add clearSensitiveData tests

kamil edited parent revisions, added: D8559: [web] implement functions to import/export database content; removed: D8557: [web] rework storage engine tests to use CommQueryExecutor.Jul 25 2023, 2:05 AM
kamil added a child revision: D8554: [web] rework report tests to use CommQueryExecutor.
kamil requested review of this revision.Jul 25 2023, 2:19 AM

added a new test so I would like to have another look from the reviewers

Harbormaster completed remote builds in B21168: Diff 29001.Jul 25 2023, 2:28 AM
michal accepted this revision.Jul 25 2023, 6:17 AM

Can we also check if the FILE_PATH contains no file (with module.FS.stat or sth)?

This revision is now accepted and ready to land.Jul 25 2023, 6:17 AM
kamil edited the summary of this revision. (Show Details)Jul 27 2023, 5:11 AM
kamil updated this revision to Diff 29121.Jul 27 2023, 5:11 AM
kamil edited the summary of this revision. (Show Details)

add module.FS.stat test

Harbormaster completed remote builds in B21271: Diff 29121.Jul 27 2023, 5:30 AM
Closed by commit rCOMM1bc7a2637aeb: [web] rework database module tests to use CommQueryExecutor (authored by kamil). · Explain WhyJul 27 2023, 5:39 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMM6bd9bba33bc9: [web] implement function to clear database content.
kamil added a commit: rCOMM1bc7a2637aeb: [web] rework database module tests to use CommQueryExecutor.

Revision Contents
Changeset List

PathSize
web/
database/
30 lines

Diff 29001

View Options

web/database/db-module.test.js

  • This file was moved from web/modals/threads/thread-settings-modal.react.js.
// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
deleteThreadActionTypes, deleteThreadActionTypes,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
} from 'lib/actions/thread-actions'; } from 'lib/actions/thread-actions.js';
import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { threadHasPermission, robotextName } from 'lib/shared/thread-utils'; import { threadHasPermission, robotextName } from 'lib/shared/thread-utils.js';
import { import {
type ThreadInfo, type ThreadInfo,
threadTypes, threadTypes,
threadPermissions, threadPermissions,
type ThreadChanges, type ThreadChanges,
} from 'lib/types/thread-types'; } from 'lib/types/thread-types.js';
import Tabs from '../../components/tabs.react'; import Tabs from '../../../components/tabs.react.js';
import { useModalContext } from '../../modals/modal-provider.react'; import { useSelector } from '../../../redux/redux-utils.js';
import { useSelector } from '../../redux/redux-utils'; import { useModalContext } from '../../modal-provider.react.js';
import Modal from '../modal.react'; import Modal from '../../modal.react.js';
import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react'; import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react.js';
import ThreadSettingsGeneralTab from './thread-settings-general-tab.react'; import ThreadSettingsGeneralTab from './thread-settings-general-tab.react.js';
import css from './thread-settings-modal.css'; import css from './thread-settings-modal.css';
import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react'; import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react.js';
type TabType = 'general' | 'privacy' | 'delete'; type TabType = 'general' | 'privacy' | 'delete';
type BaseProps = { type BaseProps = {
+threadID: string, +threadID: string,
}; };
const deleteThreadLoadingStatusSelector = createLoadingStatusSelector( const deleteThreadLoadingStatusSelector = createLoadingStatusSelector(
deleteThreadActionTypes, deleteThreadActionTypes,
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines
View Options

web/database/sql-js.test.js

  • This file was moved from web/modals/threads/thread-settings-modal.react.js.
// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
deleteThreadActionTypes, deleteThreadActionTypes,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
} from 'lib/actions/thread-actions'; } from 'lib/actions/thread-actions.js';
import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { threadHasPermission, robotextName } from 'lib/shared/thread-utils'; import { threadHasPermission, robotextName } from 'lib/shared/thread-utils.js';
import { import {
type ThreadInfo, type ThreadInfo,
threadTypes, threadTypes,
threadPermissions, threadPermissions,
type ThreadChanges, type ThreadChanges,
} from 'lib/types/thread-types'; } from 'lib/types/thread-types.js';
import Tabs from '../../components/tabs.react'; import Tabs from '../../../components/tabs.react.js';
import { useModalContext } from '../../modals/modal-provider.react'; import { useSelector } from '../../../redux/redux-utils.js';
import { useSelector } from '../../redux/redux-utils'; import { useModalContext } from '../../modal-provider.react.js';
import Modal from '../modal.react'; import Modal from '../../modal.react.js';
import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react'; import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react.js';
import ThreadSettingsGeneralTab from './thread-settings-general-tab.react'; import ThreadSettingsGeneralTab from './thread-settings-general-tab.react.js';
import css from './thread-settings-modal.css'; import css from './thread-settings-modal.css';
import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react'; import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react.js';
type TabType = 'general' | 'privacy' | 'delete'; type TabType = 'general' | 'privacy' | 'delete';
type BaseProps = { type BaseProps = {
+threadID: string, +threadID: string,
}; };
const deleteThreadLoadingStatusSelector = createLoadingStatusSelector( const deleteThreadLoadingStatusSelector = createLoadingStatusSelector(
deleteThreadActionTypes, deleteThreadActionTypes,
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines