[web] rework report tests to use CommQueryExecutor
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 6:53 AM.

Details

Reviewers

michal
tomek

Commits

rCOMM31dc137a10f9: [web] rework report tests to use CommQueryExecutor

Summary

Updates test to new module

Depends on D8553

Test Plan

Run tests

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 19 2023, 6:53 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 6:53 AM

kamil added a child revision: D8555: [web] rework metadata tests to use CommQueryExecutor.Jul 19 2023, 6:55 AM

Harbormaster completed remote builds in B21033: Diff 28829.Jul 19 2023, 7:14 AM

kamil published this revision for review.Jul 19 2023, 9:02 AM

kamil added inline comments.

web/database/queries/report-queries.test.js
34 ↗	(On Diff #28829)	this test is no longer relevant, table is created via native code

Nice!

This revision is now accepted and ready to land.Jul 21 2023, 5:59 AM

rebase

kamil edited parent revisions, added: D8558: [web] rework database module tests to use CommQueryExecutor; removed: D8553: [web] add SQLiteQueryExecutor bindings and type.Jul 25 2023, 2:07 AM

Harbormaster completed remote builds in B21169: Diff 29002.Jul 25 2023, 2:41 AM

Closed by commit rCOMM31dc137a10f9: [web] rework report tests to use CommQueryExecutor (authored by kamil). · Explain WhyJul 27 2023, 5:40 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM31dc137a10f9: [web] rework report tests to use CommQueryExecutor.

Revision Contents
Changeset List

Path

Size

web/

database/

queries/

report-queries.test.js

61 lines

Diff 29002

View Options

web/database/queries/report-queries.test.js

[web] rework report tests to use CommQueryExecutorClosedPublicActions