Page MenuHomePhabricator
Differential D8612

[web] handle clearing sensitive data on database module
ClosedPublic
Actions

Authored by kamil on Jul 25 2023, 2:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 7:07 AM
Unknown Object (File)
Tue, Nov 5, 7:07 AM
Unknown Object (File)
Tue, Nov 5, 7:07 AM
Unknown Object (File)
Tue, Nov 5, 7:04 AM
Unknown Object (File)
Fri, Nov 1, 3:57 PM
Unknown Object (File)
Oct 2 2024, 10:01 PM
Unknown Object (File)
Sep 28 2024, 1:55 AM
Unknown Object (File)
Sep 28 2024, 1:55 AM
View All 80 Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM7db2bf4d7751: [web] handle clearing sensitive data on database module
Summary

Right now in addition to delete indexedDB content we're also deleting virtual file and destructing module.

Test Plan

Test login/logout

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 25 2023, 2:15 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 25 2023, 2:15 AM
kamil added a parent revision: D8560: [web] switch code from `sql.js` API to `.wasm` database module.Jul 25 2023, 2:15 AM
kamil added a child revision: D8561: [web] remove old raw SQL queries.
kamil published this revision for review.Jul 25 2023, 2:23 AM
kamil added inline comments.
web/database/worker/db-worker.js
150–151

Flow forced this because of this sqliteQueryExecutor = null; in line 221

Harbormaster failed remote builds in B21174: Diff 29007!Jul 25 2023, 3:50 AM
Harbormaster completed remote builds in B21174: Diff 29007.Jul 25 2023, 4:36 AM
michal accepted this revision.Jul 25 2023, 6:19 AM

We could probably simplify error handling by passing sqliteQueryExecutor as an argument (that's never null) to the operation handling functions. And move all "Database not initialized" error handling to the main funciton

This revision is now accepted and ready to land.Jul 25 2023, 6:19 AM
kamil added a comment.Jul 27 2023, 5:26 AM
In D8612#253783, @michal wrote:

We could probably simplify error handling by passing sqliteQueryExecutor as an argument (that's never null) to the operation handling functions. And move all "Database not initialized" error handling to the main funciton

Good call, created ENG-4522

Closed by commit rCOMM7db2bf4d7751: [web] handle clearing sensitive data on database module (authored by kamil). · Explain WhyJul 27 2023, 7:38 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM7db2bf4d7751: [web] handle clearing sensitive data on database module.
kamil mentioned this in D8670: [web] refactor processing store operations on worker.Jul 31 2023, 2:27 AM
kamil mentioned this in rCOMM1af81091dfc5: [web] refactor processing store operations on worker.Aug 1 2023, 3:15 AM

Revision Contents
Changeset List

PathSize
web/
database/
worker/
33 lines

Diff 29007

View Options

web/database/worker/db-worker.js

Loading...