[landing] introduce telegram competitor data
ClosedPublic
Actions

Authored by ginsu on May 30 2023, 9:10 AM.

Details

Reviewers

atul
kamil

Commits

rCOMMbcc40390ddd5: [landing] introduce telegram competitor data

Summary

introduce telegram competitor data. The copy was copied and pasted from this linear task.

Depends on D8032

Test Plan

Please see screenshots below:

Screenshot 2023-08-06 at 3.50.45 PM.png (2×3 px, 893 KB)

Screenshot 2023-08-06 at 3.50.47 PM.png (2×3 px, 843 KB)

Screenshot 2023-08-06 at 3.51.00 PM.png (2×3 px, 973 KB)

Screenshot 2023-08-06 at 3.50.56 PM.png (2×3 px, 1011 KB)

Screenshot 2023-08-06 at 3.51.05 PM.png (2×3 px, 1013 KB)

Screenshot 2023-08-06 at 3.50.49 PM.png (2×3 px, 1017 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 30 2023, 9:10 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 30 2023, 9:10 AM

ginsu edited the summary of this revision. (Show Details)May 30 2023, 9:11 AM

ginsu added a parent revision: D8032: [landing] introduce slack competitor data.

Harbormaster returned this revision to the author for changes because remote builds failed.May 30 2023, 9:40 AM

Harbormaster failed remote builds in B19908: Diff 27270!

add key

Harbormaster completed remote builds in B19914: Diff 27276.May 30 2023, 11:55 AM

ginsu requested review of this revision.May 30 2023, 11:55 AM

ginsu added a child revision: D8034: [landing] introduce competitor comparison.May 31 2023, 8:49 AM

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Harbormaster completed remote builds in B21006: Diff 28796.Jul 18 2023, 2:45 PM

update copy

ginsu retitled this revision from DRAFT [landing] introduce telegram competitor data to [landing] introduce telegram competitor data.Aug 6 2023, 1:57 PM

ginsu edited the summary of this revision. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu edited the test plan for this revision. (Show Details)

ginsu attached a referenced file: F677189: Screenshot 2023-08-06 at 3.50.49 PM.png. (Show Details)

ginsu attached a referenced file: F677190: Screenshot 2023-08-06 at 3.50.47 PM.png. (Show Details)

ginsu attached a referenced file: F677191: Screenshot 2023-08-06 at 3.51.05 PM.png. (Show Details)

ginsu attached a referenced file: F677192: Screenshot 2023-08-06 at 3.50.56 PM.png. (Show Details)

ginsu attached a referenced file: F677188: Screenshot 2023-08-06 at 3.51.00 PM.png. (Show Details)

ginsu attached a referenced file: F677187: Screenshot 2023-08-06 at 3.50.45 PM.png. (Show Details)

Harbormaster completed remote builds in B21556: Diff 29572.Aug 6 2023, 2:10 PM

atul accepted this revision.Aug 7 2023, 10:30 PM

This revision is now accepted and ready to land.Aug 7 2023, 10:30 PM

rebase before landing

Harbormaster completed remote builds in B21625: Diff 29671.Aug 8 2023, 1:27 PM

Closed by commit rCOMMbcc40390ddd5: [landing] introduce telegram competitor data (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMbcc40390ddd5: [landing] introduce telegram competitor data.

Revision Contents
Changeset List

Path

Size

landing/

competitor-data.js

87 lines

Diff 29671

View Options

landing/competitor-data.js

	Show All 27 Lines
	import {			import {
	type ServerServerRequest,			type ServerServerRequest,
	serverServerRequestValidator,			serverServerRequestValidator,
	type ClientServerRequest,			type ClientServerRequest,
	type ClientResponse,			type ClientResponse,
	type ClientClientResponse,			type ClientClientResponse,
	} from './request-types.js';			} from './request-types.js';
	import type { SessionState, SessionIdentification } from './session-types.js';			import type { SessionState, SessionIdentification } from './session-types.js';
	import { type RawThreadInfos } from './thread-types.js';			import type {
				RawThreadInfos,
				MinimallyEncodedRawThreadInfos,
				} from './thread-types.js';
	import {			import {
	type ClientUpdatesResult,			type ClientUpdatesResult,
	type ClientUpdatesResultWithUserInfos,			type ClientUpdatesResultWithUserInfos,
	type ServerUpdatesResult,			type ServerUpdatesResult,
	serverUpdatesResultValidator,			serverUpdatesResultValidator,
	type ServerUpdatesResultWithUserInfos,			type ServerUpdatesResultWithUserInfos,
	serverUpdatesResultWithUserInfosValidator,			serverUpdatesResultWithUserInfosValidator,
	} from './update-types.js';			} from './update-types.js';
	▲ Show 20 Lines • Show All 134 Lines • ▼ Show 20 Lines
	export const stateSyncPayloadTypes = Object.freeze({			export const stateSyncPayloadTypes = Object.freeze({
	FULL: 0,			FULL: 0,
	INCREMENTAL: 1,			INCREMENTAL: 1,
	});			});

	export const fullStateSyncActionType = 'FULL_STATE_SYNC';			export const fullStateSyncActionType = 'FULL_STATE_SYNC';
	export type BaseFullStateSync = {			export type BaseFullStateSync = {
	+messagesResult: MessagesResponse,			+messagesResult: MessagesResponse,
	+threadInfos: RawThreadInfos,
	+rawEntryInfos: $ReadOnlyArray<RawEntryInfo>,			+rawEntryInfos: $ReadOnlyArray<RawEntryInfo>,
	+userInfos: $ReadOnlyArray<UserInfo>,			+userInfos: $ReadOnlyArray<UserInfo>,
	+updatesCurrentAsOf: number,			+updatesCurrentAsOf: number,
	};			};
	const baseFullStateSyncValidator = tShape<BaseFullStateSync>({			const baseFullStateSyncValidator = tShape<BaseFullStateSync>({
	messagesResult: messagesResponseValidator,			messagesResult: messagesResponseValidator,
	threadInfos: t.dict(tID, rawThreadInfoValidator),
	rawEntryInfos: t.list(rawEntryInfoValidator),			rawEntryInfos: t.list(rawEntryInfoValidator),
	userInfos: t.list(userInfoValidator),			userInfos: t.list(userInfoValidator),
	updatesCurrentAsOf: t.Number,			updatesCurrentAsOf: t.Number,
	});			});

	export type ClientFullStateSync = {			export type ClientFullStateSync = $ReadOnly<{
	...BaseFullStateSync,			...BaseFullStateSync,
				+threadInfos: MinimallyEncodedRawThreadInfos,
	+currentUserInfo: CurrentUserInfo,			+currentUserInfo: CurrentUserInfo,
	};			}>;
	export type StateSyncFullActionPayload = {			export type StateSyncFullActionPayload = $ReadOnly<{
	...ClientFullStateSync,			...ClientFullStateSync,
	+calendarQuery: CalendarQuery,			+calendarQuery: CalendarQuery,
	+keyserverID: string,			+keyserverID: string,
	};			}>;
	export type ClientStateSyncFullSocketPayload = {			export type ClientStateSyncFullSocketPayload = $ReadOnly<{
	...ClientFullStateSync,			...ClientFullStateSync,
	+type: 0,			+type: 0,
	// Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID			// Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID
	+sessionID?: string,			+sessionID?: string,
	};			}>;

	export type ServerFullStateSync = {			export type ServerFullStateSync = $ReadOnly<{
	...BaseFullStateSync,			...BaseFullStateSync,
				+threadInfos: RawThreadInfos,
	+currentUserInfo: CurrentUserInfo,			+currentUserInfo: CurrentUserInfo,
	};			}>;
	const serverFullStateSyncValidator = tShape<ServerFullStateSync>({			const serverFullStateSyncValidator = tShape<ServerFullStateSync>({
	...baseFullStateSyncValidator.meta.props,			...baseFullStateSyncValidator.meta.props,
				threadInfos: t.dict(tID, rawThreadInfoValidator),
	currentUserInfo: currentUserInfoValidator,			currentUserInfo: currentUserInfoValidator,
	});			});

	export type ServerStateSyncFullSocketPayload = {			export type ServerStateSyncFullSocketPayload = {
				atulAuthorUnsubmitted Done Inline Actions Get the following when I try making this `$ReadOnly`: atul: Get the following when I try making this `$ReadOnly`: {F1058362}
	...ServerFullStateSync,			...ServerFullStateSync,
	+type: 0,			+type: 0,
	// Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID			// Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID
	+sessionID?: string,			+sessionID?: string,
	};			};
	const serverStateSyncFullSocketPayloadValidator =			const serverStateSyncFullSocketPayloadValidator =
	tShape<ServerStateSyncFullSocketPayload>({			tShape<ServerStateSyncFullSocketPayload>({
	...serverFullStateSyncValidator.meta.props,			...serverFullStateSyncValidator.meta.props,
	▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines

[landing] introduce telegram competitor dataClosedPublicActions