Page MenuHomePhabricator
Differential D8948

[keyserver] Generalize state_check status handling using specs
ClosedPublic
Actions

Authored by tomek on Aug 25 2023, 5:27 AM.
Tags
None
Referenced Files
F3519635: D8948.id.diff
Sun, Dec 22, 10:44 PM
Unknown Object (File)
Sat, Nov 30, 5:31 PM
Unknown Object (File)
Nov 16 2024, 7:56 AM
Unknown Object (File)
Nov 15 2024, 12:33 AM
Unknown Object (File)
Nov 10 2024, 4:00 PM
Unknown Object (File)
Nov 10 2024, 4:00 PM
Unknown Object (File)
Nov 10 2024, 3:58 PM
Unknown Object (File)
Nov 5 2024, 2:12 AM
View All 73 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
inka
Commits
rCOMM09562b850b78: [keyserver] Generalize state_check status handling using specs
Summary

Instead of computing hash for each store by hand, iterate over specs and compute all the hashes for them.

https://linear.app/comm/issue/ENG-4631/migrate-checkstate-from-session-utils-to-a-spec

Depends on D8946

Test Plan

Bring back the old hash logic and compare the results with the new version.

Diff Detail

Repository
rCOMM Comm
Branch
state-sync
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 30312

View Options

keyserver/src/shared/state-sync/current-user-state-sync-spec.js

Loading...
View Options

keyserver/src/shared/state-sync/entries-state-sync-spec.js

Loading...
View Options

keyserver/src/shared/state-sync/state-sync-spec.js

Loading...
View Options

keyserver/src/shared/state-sync/threads-state-sync-spec.js

Loading...
View Options

keyserver/src/shared/state-sync/users-state-sync-spec.js

Loading...
View Options

keyserver/src/socket/session-utils.js

Loading...