[keyserver] Use specs to compute invalid top-level keys
ClosedPublic
Actions

Authored by tomek on Aug 25 2023, 5:46 AM.

Details

Reviewers

kamil
bartek
inka

Commits

rCOMM7f4d6ac902d9: [keyserver] Use specs to compute invalid top-level keys

Summary

Iterate over specs and check if their key is mentioned as invalid.

https://linear.app/comm/issue/ENG-4631/migrate-checkstate-from-session-utils-to-a-spec

Depends on D8948

Test Plan

Modify keyserver db and check if the store get fixed.

Diff Detail

Repository

rCOMM Comm

Branch

state-sync

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 25 2023, 5:46 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 25 2023, 5:46 AM

Harbormaster completed remote builds in B22085: Diff 30313.Aug 25 2023, 6:03 AM

tomek requested review of this revision.Aug 25 2023, 6:03 AM

bartek accepted this revision.Aug 25 2023, 7:36 AM

This revision is now accepted and ready to land.Aug 25 2023, 7:36 AM

tomek added a child revision: D8976: [keyserver] Determine which ids to fetch based on specs.Aug 28 2023, 5:08 AM

Closed by commit rCOMM7f4d6ac902d9: [keyserver] Use specs to compute invalid top-level keys (authored by tomek). · Explain WhyAug 30 2023, 9:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM7f4d6ac902d9: [keyserver] Use specs to compute invalid top-level keys.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

socket/

session-utils.js

30 lines

Diff 30313

View Options

keyserver/src/socket/session-utils.js

[keyserver] Use specs to compute invalid top-level keysClosedPublicActions