[lib] Make selector types more consistent
ClosedPublic
Actions

Authored by tomek on Aug 30 2023, 2:45 PM.

Details

Reviewers

kamil
bartek
inka

Commits

rCOMM3e33858c2d9d: [lib] Make selector types more consistent

Summary

Use the types that are already defined.

https://linear.app/comm/issue/ENG-4813/migrate-getclientresponsesselector-to-a-spec

Depends on D9009

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

state-sync

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 30 2023, 2:45 PM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 30 2023, 2:45 PM

Harbormaster completed remote builds in B22264: Diff 30561.Aug 30 2023, 3:02 PM

tomek requested review of this revision.Aug 30 2023, 3:02 PM

tomek added a child revision: D9030: [lib] Convert infos to server as a part of a spec.Aug 30 2023, 4:05 PM

bartek accepted this revision.Aug 30 2023, 7:12 PM

This revision is now accepted and ready to land.Aug 30 2023, 7:12 PM

Closed by commit rCOMM3e33858c2d9d: [lib] Make selector types more consistent. · Explain WhySep 5 2023, 2:03 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM3e33858c2d9d: [lib] Make selector types more consistent.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

thread-fetchers.js

5 lines

shared/

state-sync/

threads-state-sync-spec.js

6 lines

lib/

selectors/

socket-selectors.js

8 lines

types/

thread-types.js

3 lines

Diff 30561

View Options

keyserver/src/fetchers/thread-fetchers.js

View Options

keyserver/src/shared/state-sync/threads-state-sync-spec.js

View Options

lib/selectors/socket-selectors.js

View Options

[lib] Make selector types more consistentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30561

keyserver/src/fetchers/thread-fetchers.js

keyserver/src/shared/state-sync/threads-state-sync-spec.js

lib/selectors/socket-selectors.js

lib/types/thread-types.js

[lib] Make selector types more consistent
ClosedPublic
Actions

Revision Contents
Changeset List