Paths

Table of Contentst

[lib] Extract shared specs to a lib
ClosedPublic
Actions

Authored by tomek on Aug 29 2023, 7:31 AM.

Details

Reviewers

kamil
bartek
inka

Commits

rCOMMee2829fe9a40: [lib] Extract shared specs to a lib

Summary

A part of a spec will be used in a lib. We can't migrate the whole spec there because fetch function is server-specific.

Depends on D9008

https://linear.app/comm/issue/ENG-4813/migrate-getclientresponsesselector-to-a-spec

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 29 2023, 7:31 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 29 2023, 7:31 AM

Harbormaster completed remote builds in B22222: Diff 30498.Aug 29 2023, 7:49 AM

tomek requested review of this revision.Aug 29 2023, 7:49 AM

bartek accepted this revision.Aug 29 2023, 8:12 AM

This revision is now accepted and ready to land.Aug 29 2023, 8:12 AM

tomek added a child revision: D9025: [lib] Make selector types more consistent.Aug 30 2023, 7:45 AM

Closed by commit rCOMMee2829fe9a40: [lib] Extract shared specs to a lib (authored by tomek). · Explain WhyAug 30 2023, 9:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMee2829fe9a40: [lib] Extract shared specs to a lib.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

shared/

state-sync/

current-user-state-sync-spec.js

7 lines

entries-state-sync-spec.js

17 lines

state-sync-spec.js

11 lines

state-sync-specs.js

4 lines

threads-state-sync-spec.js

12 lines

users-state-sync-spec.js

15 lines

lib/

shared/

state-sync/

current-user-state-sync-spec.js

7 lines

entries-state-sync-spec.js

12 lines

state-sync-spec.js

11 lines

threads-state-sync-spec.js

12 lines

users-state-sync-spec.js

16 lines

	lib/		shared/	state-sync/
	keyserver/	src/	shared/	state-sync/

state-sync-specs.js

2 lines

Diff 30583

View Options

keyserver/src/shared/state-sync/current-user-state-sync-spec.js

View Options

keyserver/src/shared/state-sync/entries-state-sync-spec.js

View Options

keyserver/src/shared/state-sync/state-sync-spec.js

View Options

keyserver/src/shared/state-sync/state-sync-specs.js

View Options

keyserver/src/shared/state-sync/threads-state-sync-spec.js

View Options

keyserver/src/shared/state-sync/users-state-sync-spec.js

View Options

lib/shared/state-sync/current-user-state-sync-spec.js

View Options

lib/shared/state-sync/entries-state-sync-spec.js

View Options

lib/shared/state-sync/state-sync-spec.js

View Options

lib/shared/state-sync/state-sync-specs.js

View Options

lib/shared/state-sync/threads-state-sync-spec.js

View Options

lib/shared/state-sync/users-state-sync-spec.js

[lib] Extract shared specs to a libClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30583

keyserver/src/shared/state-sync/current-user-state-sync-spec.js

keyserver/src/shared/state-sync/entries-state-sync-spec.js

keyserver/src/shared/state-sync/state-sync-spec.js

keyserver/src/shared/state-sync/state-sync-specs.js

keyserver/src/shared/state-sync/threads-state-sync-spec.js

keyserver/src/shared/state-sync/users-state-sync-spec.js

lib/shared/state-sync/current-user-state-sync-spec.js

lib/shared/state-sync/entries-state-sync-spec.js

lib/shared/state-sync/state-sync-spec.js

lib/shared/state-sync/state-sync-specs.js

lib/shared/state-sync/threads-state-sync-spec.js

lib/shared/state-sync/users-state-sync-spec.js

[lib] Extract shared specs to a lib
ClosedPublic
Actions

Revision Contents
Changeset List