[lib] Use specs to determine hash value for top-level infos
ClosedPublic
Actions

Authored by tomek on Aug 30 2023, 9:41 AM.

Details

Reviewers

kamil
bartek
inka

Commits

rCOMM5daaf661b987: [lib] Use specs to determine hash value for top-level infos

Summary

Create convertedInfos where hashKeys are used as keys and access this object to determine for which entries we should compute a hash.

https://linear.app/comm/issue/ENG-4813/migrate-getclientresponsesselector-to-a-spec

Depends on D9030

Test Plan

Modify server state and check if state check fixes client state.

Diff Detail

Repository

rCOMM Comm

Branch

state-sync

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 30 2023, 9:41 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 30 2023, 9:41 AM

Harbormaster completed remote builds in B22275: Diff 30584.Aug 30 2023, 9:59 AM

tomek requested review of this revision.Aug 30 2023, 9:59 AM

bartek accepted this revision.Aug 31 2023, 12:34 AM

This revision is now accepted and ready to land.Aug 31 2023, 12:34 AM

tomek added a child revision: D9048: [lib] Use specs to determine hash value for inner infos.Aug 31 2023, 7:23 AM

Closed by commit rCOMM5daaf661b987: [lib] Use specs to determine hash value for top-level infos (authored by tomek). · Explain WhySep 5 2023, 7:03 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM5daaf661b987: [lib] Use specs to determine hash value for top-level infos.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

socket-selectors.js

70 lines

Diff 30584

View Options

lib/selectors/socket-selectors.js

[lib] Use specs to determine hash value for top-level infosClosedPublicActions