Paths

Table of Contentst

-
web/database/
-
database/
-
database-module-provider.js
-
sqlite-data-handler.js

[web] Move safari db key init to database module
ClosedPublic
Actions

Authored by michal on Sep 8 2023, 4:13 AM.

Details

Reviewers

kamil
atul
inka
tomek

Commits

rCOMM254a9328e508: [web] Move safari db key init to database module

Summary

Part of ENG-4844
Depends on D9105

Moved safari db initialization logic inside database-module-provider as it's more of an implementation details and simplifies future code.

Test Plan

Test in safari:

check if there's "Database initialization success" message
check if draft are still there after reload

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Sep 8 2023, 4:13 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 8 2023, 4:13 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 8 2023, 4:26 AM

Harbormaster failed remote builds in B22440: Diff 30856!

michal added a child revision: D9108: [web] Initialize database at startup on safari.Sep 8 2023, 5:31 AM

Remove localforage import from sqlite-data-handler

Harbormaster completed remote builds in B22443: Diff 30859.Sep 8 2023, 5:54 AM

michal requested review of this revision.Sep 8 2023, 5:54 AM

kamil accepted this revision.Sep 10 2023, 11:41 PM

This revision is now accepted and ready to land.Sep 10 2023, 11:41 PM

Closed by commit rCOMM254a9328e508: [web] Move safari db key init to database module (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 18 2023, 3:26 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM254a9328e508: [web] Move safari db key init to database module.

Revision Contents
Changeset List

Path

Size

web/

database/

database-module-provider.js

29 lines

sqlite-data-handler.js

28 lines

Diff 30859

View Options

web/database/database-module-provider.js