issue: https://linear.app/comm/issue/ENG-4682/create-a-function-to-extract-keyserver-id-from-ids
We need a function that will allow us to extract the keyserver id from message/thread/etc id
Details
Ran the provided test suite
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/actions
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
This does not handle pending threads (more precisely sidebars created from a message). It's might be fine depending on the use case but I it feel like it should have a code comment in that case. Also agree with @tomek comments.
This does not handle pending threads (more precisely sidebars created from a message)
Pending threads exist in two contexts: pending sidebars, and pending chats created via the "Create new chat" interface.
Curiously, it does appear that BaseNewThreadRequest takes an optional id field. However, threadRequestValidationShape excludes this, meaning that it's only possible to set the id of a new thread from the keyserver. As such, I don't think pending thread IDs ever get passed up in an action... so this should (hopefully) be safe.