Page MenuHomePhabricator

[blob] Add db helpers for cleanup
ClosedPublic

Authored by bartek on Oct 4 2023, 3:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 12:58 AM
Unknown Object (File)
Tue, Nov 12, 10:49 PM
Unknown Object (File)
Sun, Nov 10, 12:40 PM
Unknown Object (File)
Sun, Nov 3, 12:15 AM
Unknown Object (File)
Sun, Nov 3, 12:15 AM
Unknown Object (File)
Sun, Nov 3, 12:15 AM
Unknown Object (File)
Sat, Nov 2, 11:55 PM
Unknown Object (File)
Wed, Oct 30, 3:36 AM
Subscribers

Details

Summary

This replaces D8452 - I have reimplemented these methods using new batch helpers. These functions are needed for blob cleanup.

Depends on D9348

Test Plan

Called these on a test dataset (containing combinations of checked and unchecked blobs and holders):

  • list_existing_keys - returns the same keys as given input if they exist in db. For a list of non-existing keys, an empty Vec is returned.
  • find_unchecked_items - confirmed that it returned only items that have unchecked attribute set.
  • batch_mark_checked - confirmed that items previously having checked attribute, no longer have it.
  • batch_delete_rows - confirmed that items are deleted from db.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage