[web] introduce UserProfileMessageButton
ClosedPublic
Actions

Authored by ginsu on Oct 9 2023, 12:30 AM.

Details

Reviewers

atul
inka

Commits

rCOMM04ffaeeb5362: [web] introduce UserProfileMessageButton

Summary

This diff introduces the UserProfileMessageButton. The UserProfileMessageButtons will be responsible for navigating to the personal thread between the user and the viewer. For all of this logic we can simply just use the useUserProfileThreadInfo hook

https://linear.app/comm/issue/ENG-4966/introduceport-userprofilemessagebutton

Depends on D9411

Test Plan

Please see the demo video below

Anonymous user:

Screenshot 2023-10-09 at 3.34.32 AM.png (2×3 px, 751 KB)

Block in either direction:

Screenshot 2023-10-09 at 3.40.44 AM.png (1×3 px, 630 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 9 2023, 12:30 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 9 2023, 12:30 AM

ginsu edited the summary of this revision. (Show Details)Oct 9 2023, 12:42 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9411: [web] introduce copy username functionality to user profiles.

ginsu attached a referenced file: F804468: Screenshot 2023-10-09 at 3.40.44 AM.png. (Show Details)

ginsu attached a referenced file: F804461: Screenshot 2023-10-09 at 3.34.32 AM.png. (Show Details)

ginsu attached a referenced file: F804470: Screen Recording 2023-10-09 at 3.41.25 AM.mov. (Show Details)

Harbormaster completed remote builds in B23079: Diff 31772.Oct 9 2023, 12:47 AM

ginsu requested review of this revision.Oct 9 2023, 12:47 AM

ginsu added a child revision: D9431: [web] introduce UserProfileActionButtons.Oct 9 2023, 10:23 AM

atul accepted this revision.Oct 9 2023, 1:58 PM

atul added inline comments.

web/modals/user-profile/user-profile-message-button.react.js
31–39 ↗	(On Diff #31772)	Can we memoize with `useMemo`
web/modals/user-profile/user-profile.react.js
53–74 ↗	(On Diff #31772)	Let's def memoize, there's a lot of components nested within here would be good to short-circuit re-renders