Page MenuHomePhabricator
Differential D9447

[web] implement RelationshipPromptButtons into user profiles
ClosedPublic
Actions

Authored by ginsu on Oct 10 2023, 12:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 7:27 AM
Unknown Object (File)
Thu, Nov 14, 7:27 AM
Unknown Object (File)
Thu, Nov 14, 7:27 AM
Unknown Object (File)
Thu, Nov 14, 7:27 AM
Unknown Object (File)
Thu, Nov 14, 7:25 AM
Unknown Object (File)
Thu, Nov 14, 7:08 AM
Unknown Object (File)
Thu, Oct 24, 10:13 PM
Unknown Object (File)
Thu, Oct 24, 8:35 AM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM752ab9d7c9bc: [web] implement RelationshipPromptButtons into user profiles
Summary

This diff adds the RelationshipPromptButton to the UserProfileActionButtons component. The UserProfileActionButtons now handles rendering the different layout of the action buttons on the user profile depending on what the condtion of the relationship status is

Linear Task: https://linear.app/comm/issue/ENG-4967/introduceport-userprofilerelationshipbutton

Depends on D9446

Test Plan

Please see screenshots below

Not a friend:

Screenshot 2023-10-10 at 3.31.16 PM.png (1×3 px, 802 KB)

Sent Friend Request:

Screenshot 2023-10-10 at 3.31.18 PM.png (1×3 px, 813 KB)

Received Friend Request:

Screenshot 2023-10-10 at 3.31.11 PM.png (1×3 px, 815 KB)

Friend:

Screenshot 2023-10-10 at 3.35.24 PM.png (1×3 px, 751 KB)

Blocked:

Screenshot 2023-10-10 at 5.08.38 PM.png (1×3 px, 599 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 10 2023, 12:26 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 10 2023, 12:26 PM
ginsu edited the summary of this revision. (Show Details)Oct 10 2023, 12:39 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9446: [web] update RelationshipPromptButton to be more reusable.
ginsu attached a referenced file: F807759: Screenshot 2023-10-10 at 3.35.24 PM.png. (Show Details)
ginsu attached a referenced file: F807758: Screenshot 2023-10-10 at 3.31.11 PM.png. (Show Details)
ginsu attached a referenced file: F807757: Screenshot 2023-10-10 at 3.31.18 PM.png. (Show Details)
ginsu attached a referenced file: F807756: Screenshot 2023-10-10 at 3.31.16 PM.png. (Show Details)
ginsu added inline comments.Oct 10 2023, 12:41 PM
web/modals/user-profile/user-profile-modal.react.js
26 ↗(On Diff #31883)

Now that we have different widths/sizes due to the different layouts of the action buttons for user profiles we need to set the size to fit-content. This does create the following regression (when there is a block in either direction or the user is anonymous), and I will address this in a subsequent diff

Screenshot 2023-10-10 at 3.37.36 PM.png (1×3 px, 589 KB)

ginsu attached a referenced file: F807765: Screenshot 2023-10-10 at 3.37.36 PM.png. (Show Details)Oct 10 2023, 12:41 PM
Harbormaster completed remote builds in B23154: Diff 31883.Oct 10 2023, 12:45 PM
ginsu requested review of this revision.Oct 10 2023, 12:45 PM
ginsu planned changes to this revision.Oct 10 2023, 1:37 PM

Found a better way to address regression mentioned in inline comment

ginsu updated this revision to Diff 31884.Oct 10 2023, 2:07 PM

update

ginsu edited the test plan for this revision. (Show Details)Oct 10 2023, 2:09 PM
ginsu attached a referenced file: F807828: Screenshot 2023-10-10 at 5.08.38 PM.png. (Show Details)
Harbormaster completed remote builds in B23155: Diff 31884.Oct 10 2023, 2:27 PM
ginsu added a child revision: D9455: [web] introduce secondaryHeaderButton prop to Modal component.Oct 12 2023, 12:57 AM
atul accepted this revision.Oct 16 2023, 9:30 AM

Looks good. Probably possible to break apart the memoized block to reduce indentation, but not a priority.. good to land as is

This revision is now accepted and ready to land.Oct 16 2023, 9:30 AM
ginsu updated this revision to Diff 32053.Oct 16 2023, 10:15 PM

rebase before landing

Harbormaster completed remote builds in B23276: Diff 32053.Oct 16 2023, 10:32 PM
Closed by commit rCOMM752ab9d7c9bc: [web] implement RelationshipPromptButtons into user profiles (authored by ginsu). · Explain WhyOct 16 2023, 10:58 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM752ab9d7c9bc: [web] implement RelationshipPromptButtons into user profiles.

Revision Contents
Changeset List

PathSize
web/
modals/
user-profile/
83 lines
12 lines

Diff 32053

View Options

web/modals/user-profile/user-profile-action-buttons.react.js

Loading...
View Options

web/modals/user-profile/user-profile.css

Loading...