Page MenuHomePhabricator
Differential D9724

[native] update Keyserver selection => to be Keyservers in profile settings
ClosedPublic
Actions

Authored by ginsu on Nov 6 2023, 7:03 AM.
Tags
None
Referenced Files
F3247526: D9724.id32908.diff
Fri, Nov 15, 5:44 AM
F3247520: D9724.id32780.diff
Fri, Nov 15, 5:39 AM
F3247212: D9724.diff
Fri, Nov 15, 3:57 AM
Unknown Object (File)
Sun, Oct 27, 11:48 PM
Unknown Object (File)
Sun, Oct 27, 11:48 PM
Unknown Object (File)
Sun, Oct 27, 11:48 PM
Unknown Object (File)
Sun, Oct 27, 11:48 PM
Unknown Object (File)
Sun, Oct 27, 11:43 PM
View All 56 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
rohan
michal
inka
Commits
rCOMMcd08d18c14f3: [native] update Keyserver selection => to be Keyservers in profile settings
Summary

This was a copy change we discussed in last friday's design sync.

Test Plan

Confirmed that Keyserver selection now says Keyservers

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 6 2023, 7:03 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 6 2023, 7:03 AM
ginsu added reviewers: rohan, michal, inka.Nov 6 2023, 7:03 AM
ginsu added a child revision: D9725: [native] factor keyserver list item into its own component.Nov 6 2023, 7:08 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 6 2023, 7:32 AM
Harbormaster failed remote builds in B23792: Diff 32780!
Harbormaster completed remote builds in B23792: Diff 32780.Nov 6 2023, 8:13 AM
ginsu requested review of this revision.Nov 6 2023, 8:13 AM
inka accepted this revision.Nov 7 2023, 6:48 AM
This revision is now accepted and ready to land.Nov 7 2023, 6:48 AM
ginsu updated this revision to Diff 32905.Nov 7 2023, 10:31 AM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 7 2023, 10:37 AM
Closed by commit rCOMMcd08d18c14f3: [native] update Keyserver selection => to be Keyservers in profile settings (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMcd08d18c14f3: [native] update Keyserver selection => to be Keyservers in profile settings.
Harbormaster completed remote builds in B23874: Diff 32905.Nov 8 2023, 7:53 AM

Revision Contents
Changeset List

PathSize
native/
profile/
2 lines

Diff 32908

View Options

native/profile/profile-screen.react.js

Loading...