Page MenuHomePhabricator
Differential D9801

[lib] refactor processing updates in `UserStore` to ops
ClosedPublic
Actions

Authored by kamil on Nov 9 2023, 6:19 AM.
Tags
None
Referenced Files
F3391091: D9801.id33289.diff
Sat, Nov 30, 2:13 AM
Unknown Object (File)
Tue, Nov 26, 11:30 PM
Unknown Object (File)
Tue, Nov 26, 10:35 PM
Unknown Object (File)
Tue, Nov 26, 10:30 PM
Unknown Object (File)
Mon, Nov 25, 9:24 PM
Unknown Object (File)
Mon, Nov 25, 7:47 PM
Unknown Object (File)
Sun, Nov 24, 3:38 PM
Unknown Object (File)
Wed, Nov 20, 2:55 PM
View All Files
Subscribers
ashoat
will

Details

Reviewers
tomek
Commits
rCOMMb61ead9b2ed6: [lib] refactor processing updates in `UserStore` to ops
Summary

Convert logic for ops approach.

Depends on D9800

Test Plan
  1. Login to two accounts that have friend relationship
  2. On second delete account
  3. On first make sure update is properly processed

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 9 2023, 6:19 AM
kamil held this revision as a draft.
Herald added subscribers: will, ashoat. · View Herald TranscriptNov 9 2023, 6:19 AM
kamil added a child revision: D9802: [lib] refactor logout action in `UserStore` to ops.Nov 9 2023, 6:20 AM
Harbormaster completed remote builds in B23960: Diff 33012.Nov 9 2023, 7:10 AM
kamil published this revision for review.Nov 10 2023, 1:54 AM
tomek requested changes to this revision.Nov 13 2023, 6:59 AM
tomek added inline comments.
lib/reducers/user-reducer.js
265

There is a subtle bug here: if a user is added as a part of convertUserInfosToReplaceUserOps and isn't present in state.userInfos, we won't delete it as a part of generateOpsForUserUpdates. To solve this, we should modify generateOpsForUserUpdates so that it adds an op regardless of the provided state.

This revision now requires changes to proceed.Nov 13 2023, 6:59 AM
kamil updated this revision to Diff 33289.Nov 15 2023, 12:14 PM

address review

Harbormaster completed remote builds in B24171: Diff 33289.Nov 15 2023, 1:47 PM
tomek accepted this revision.Nov 16 2023, 3:14 AM
tomek added inline comments.
lib/reducers/user-reducer.js
163 ↗(On Diff #33289)

Do we need this parameter?

This revision is now accepted and ready to land.Nov 16 2023, 3:14 AM
kamil updated this revision to Diff 33331.Nov 16 2023, 6:52 AM

remove unused param

This revision was landed with ongoing or failed builds.Nov 16 2023, 7:21 AM
Closed by commit rCOMMb61ead9b2ed6: [lib] refactor processing updates in `UserStore` to ops (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMb61ead9b2ed6: [lib] refactor processing updates in `UserStore` to ops.
Harbormaster completed remote builds in B24206: Diff 33331.Nov 16 2023, 7:41 AM

Revision Contents
Changeset List

PathSize
lib/
reducers/
34 lines
shared/
updates/
11 lines
5 lines

Diff 33012

View Options

lib/reducers/user-reducer.js

Loading...
View Options

lib/shared/updates/delete-account-spec.js

Loading...
View Options

lib/shared/updates/update-spec.js

Loading...