Page MenuHomePhabricator

[SQLite] add table for users
ClosedPublic

Authored by kamil on Nov 15 2023, 12:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 10:39 PM
Unknown Object (File)
Mon, Nov 25, 3:30 AM
Unknown Object (File)
Sun, Nov 24, 4:27 AM
Unknown Object (File)
Thu, Nov 7, 8:00 PM
Unknown Object (File)
Oct 27 2024, 5:22 PM
Unknown Object (File)
Oct 11 2024, 1:11 AM
Unknown Object (File)
Sep 28 2024, 9:30 PM
Unknown Object (File)
Sep 28 2024, 9:30 PM
Subscribers

Details

Summary

Table to store data from UserStore in SQLite.

Column types are based on Flow types.

Some time ago @atul suggested to make this table key-value with data in JSON - I still think for some stores it's beneficial but here I decided to make more datailed data representation. Making key-value doesn't speed things up that much, and I think at some point we might want to have easy access to user data from C++/Rust (for example avatar to show more detailed notif).

EDIT: actually that was a bad assumption, avatar can have multiple types which force us to use JSON anyway which means we will not gain anything, and the amount of C++ code is reduced a lot, that being said proceeding with a simple key-value table.

Depends on D9902

Test Plan
  1. Make sure migration works
  2. Logout and make sure creating database form scratch
  3. Test on both web (it's visible in worker's logs) and native.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
543–546 ↗(On Diff #33297)

indentation is messed here

This revision is now accepted and ready to land.Nov 17 2023, 7:08 AM
This revision was automatically updated to reflect the committed changes.