Page MenuHomePhabricator
Differential D9909

[SQLite] add functions to convert user data and tests to user store methods
ClosedPublic
Actions

Authored by kamil on Nov 16 2023, 6:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 28, 9:01 PM
Unknown Object (File)
Sat, Sep 28, 9:01 PM
Unknown Object (File)
Sat, Sep 28, 9:01 PM
Unknown Object (File)
Sat, Sep 28, 9:01 PM
Unknown Object (File)
Sat, Sep 28, 8:55 PM
Unknown Object (File)
Sep 1 2024, 3:13 PM
Unknown Object (File)
Aug 28 2024, 11:42 AM
Unknown Object (File)
Aug 28 2024, 5:00 AM
View All 73 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMMa6501a810620: [SQLite] add functions to convert user data and tests to user store methods
Summary

This tests both web and native logic.

Depends on D9904

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 16 2023, 6:16 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 16 2023, 6:16 AM
kamil added a child revision: D9910: [SQLite] implement C++ user store ops.Nov 16 2023, 6:32 AM
kamil mentioned this in D9796: [lib] implement `UserStore` spec.Nov 16 2023, 6:45 AM
Harbormaster completed remote builds in B24200: Diff 33325.Nov 16 2023, 7:06 AM
kamil published this revision for review.Nov 16 2023, 7:06 AM
kamil mentioned this in D9904: [SQLite] add methods to operate on users table.
ashoat added inline comments.Nov 16 2023, 9:52 AM
web/database/queries/user-quries.test.js
34–35

New version of Flow will require types here. Can you add them?

tomek accepted this revision.Nov 17 2023, 7:27 AM
This revision is now accepted and ready to land.Nov 17 2023, 7:27 AM
kamil updated this revision to Diff 33404.Nov 20 2023, 4:00 AM

improve Flow

Harbormaster completed remote builds in B24266: Diff 33404.Nov 20 2023, 4:20 AM
Closed by commit rCOMMa6501a810620: [SQLite] add functions to convert user data and tests to user store methods (authored by kamil). · Explain WhyNov 20 2023, 5:48 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMM5c36d95c18ad: [SQLite] add methods to operate on users table.
kamil added a commit: rCOMMa6501a810620: [SQLite] add functions to convert user data and tests to user store methods.

Revision Contents
Changeset List

PathSize
lib/
ops/
39 lines
web/
database/
queries/
92 lines

Diff 33325

View Options

lib/ops/user-store-ops.js

Loading...
View Options

web/database/queries/user-quries.test.js

Loading...