Differential D9910

[SQLite] implement C++ user store ops
ClosedPublic
Actions

Authored by kamil on Nov 16 2023, 6:32 AM.

Details

Reviewers

tomek

Commits

rCOMMa5c95cab2250: [SQLite] implement C++ user store ops

Summary

Code for native ops

Depends on D9909

Test Plan

Code for testing:

await commCoreModule.processUserStoreOperations([
  {
    type: 'replace_user',
    payload: {
      id: '1',
      userInfo: 'fdfd',
    },
  },
  {
    type: 'replace_user',
    payload: {
      id: '2',
      userInfo: 'fdfd',
    },
  },
]);

await commCoreModule.processUserStoreOperations([
  {
    type: 'replace_user',
    payload: {
      id: '2',
      userInfo: 'fdfd',
    },
  },
]);

await commCoreModule.processUserStoreOperations([
  {
    type: 'remove_users',
    payload: {
      ids: ['1'],
    },
  },
]);

await commCoreModule.processUserStoreOperations([
  {
    type: 'remove_all_users',
  },
]);

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Nov 16 2023, 6:32 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 16 2023, 6:32 AM

kamil added a child revision: D9911: [SQLite] implement C++ code to get users.Nov 16 2023, 6:35 AM

Harbormaster failed remote builds in B24201: Diff 33326!Nov 16 2023, 7:19 AM

typo

Harbormaster failed remote builds in B24207: Diff 33340!Nov 16 2023, 7:45 AM

rebase

Harbormaster completed remote builds in B24209: Diff 33342.Nov 16 2023, 8:48 AM

kamil published this revision for review.Nov 16 2023, 9:12 AM

tomek accepted this revision.Nov 17 2023, 7:46 AM

tomek added inline comments.

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.cpp
19–20 ↗	(On Diff #33342)	Is it intentional to return an empty array? Is it implemented later in the stack?

This revision is now accepted and ready to land.Nov 17 2023, 7:46 AM

kamil added inline comments.Nov 20 2023, 4:03 AM

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.cpp
19–20 ↗	(On Diff #33342)	it's implemented in next diff: D9911

Closed by commit rCOMMa5c95cab2250: [SQLite] implement C++ user store ops (authored by kamil). · Explain WhyNov 20 2023, 5:48 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa5c95cab2250: [SQLite] implement C++ user store ops.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CMakeLists.txt

3 lines

CommCoreModule.h

4 lines

CommCoreModule.cpp

9 lines

PersistentStorageUtilities/

DataStores/

UserStore.h

29 lines

UserStore.cpp

62 lines

UserStoreOperations.h

47 lines

_generated/

commJSI-generated.cpp

commJSI.h

ios/

Comm.xcodeproj/

project.pbxproj

8 lines

schema/

CommCoreModuleSchema.js

4 lines

Diff 33326

View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines	interface Spec extends TurboModule {
+getCurrentUserID: () => Promise<string>;		+getCurrentUserID: () => Promise<string>;
+setDeviceID: (deviceType: string) => Promise<string>;		+setDeviceID: (deviceType: string) => Promise<string>;
+getDeviceID: () => Promise<string>;		+getDeviceID: () => Promise<string>;
+clearSensitiveData: () => Promise<void>;		+clearSensitiveData: () => Promise<void>;
+checkIfDatabaseNeedsDeletion: () => boolean;		+checkIfDatabaseNeedsDeletion: () => boolean;
+reportDBOperationsFailure: () => void;		+reportDBOperationsFailure: () => void;
+computeBackupKey: (password: string, backupID: string) => Promise<Object>;		+computeBackupKey: (password: string, backupID: string) => Promise<Object>;
+generateRandomString: (size: number) => Promise<string>;		+generateRandomString: (size: number) => Promise<string>;
		+setCommServicesAccessToken: (accessToken: string) => Promise<void>;
		+getCommServicesAccessToken: () => Promise<string>;
		+clearCommServicesAccessToken: () => Promise<void>;
}		}

export interface CoreModuleSpec extends Spec {		export interface CoreModuleSpec extends Spec {
+computeBackupKey: (		+computeBackupKey: (
password: string,		password: string,
backupID: string,		backupID: string,
) => Promise<ArrayBuffer>;		) => Promise<ArrayBuffer>;
}		}

export default (TurboModuleRegistry.getEnforcing<Spec>(		export default (TurboModuleRegistry.getEnforcing<Spec>(
'CommTurboModule',		'CommTurboModule',
): Spec);		): Spec);

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines	interface Spec extends TurboModule {
+getCurrentUserID: () => Promise<string>;		+getCurrentUserID: () => Promise<string>;
+setDeviceID: (deviceType: string) => Promise<string>;		+setDeviceID: (deviceType: string) => Promise<string>;
+getDeviceID: () => Promise<string>;		+getDeviceID: () => Promise<string>;
+clearSensitiveData: () => Promise<void>;		+clearSensitiveData: () => Promise<void>;
+checkIfDatabaseNeedsDeletion: () => boolean;		+checkIfDatabaseNeedsDeletion: () => boolean;
+reportDBOperationsFailure: () => void;		+reportDBOperationsFailure: () => void;
+computeBackupKey: (password: string, backupID: string) => Promise<Object>;		+computeBackupKey: (password: string, backupID: string) => Promise<Object>;
+generateRandomString: (size: number) => Promise<string>;		+generateRandomString: (size: number) => Promise<string>;
		+setCommServicesAccessToken: (accessToken: string) => Promise<void>;
		+getCommServicesAccessToken: () => Promise<string>;
		+clearCommServicesAccessToken: () => Promise<void>;
}		}

export interface CoreModuleSpec extends Spec {		export interface CoreModuleSpec extends Spec {
+computeBackupKey: (		+computeBackupKey: (
password: string,		password: string,
backupID: string,		backupID: string,
) => Promise<ArrayBuffer>;		) => Promise<ArrayBuffer>;
}		}

export default (TurboModuleRegistry.getEnforcing<Spec>(		export default (TurboModuleRegistry.getEnforcing<Spec>(
'CommTurboModule',		'CommTurboModule',
): Spec);		): Spec);

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines	interface Spec extends TurboModule {
+getCurrentUserID: () => Promise<string>;		+getCurrentUserID: () => Promise<string>;
+setDeviceID: (deviceType: string) => Promise<string>;		+setDeviceID: (deviceType: string) => Promise<string>;
+getDeviceID: () => Promise<string>;		+getDeviceID: () => Promise<string>;
+clearSensitiveData: () => Promise<void>;		+clearSensitiveData: () => Promise<void>;
+checkIfDatabaseNeedsDeletion: () => boolean;		+checkIfDatabaseNeedsDeletion: () => boolean;
+reportDBOperationsFailure: () => void;		+reportDBOperationsFailure: () => void;
+computeBackupKey: (password: string, backupID: string) => Promise<Object>;		+computeBackupKey: (password: string, backupID: string) => Promise<Object>;
+generateRandomString: (size: number) => Promise<string>;		+generateRandomString: (size: number) => Promise<string>;
		+setCommServicesAccessToken: (accessToken: string) => Promise<void>;
		+getCommServicesAccessToken: () => Promise<string>;
		+clearCommServicesAccessToken: () => Promise<void>;
}		}

export interface CoreModuleSpec extends Spec {		export interface CoreModuleSpec extends Spec {
+computeBackupKey: (		+computeBackupKey: (
password: string,		password: string,
backupID: string,		backupID: string,
) => Promise<ArrayBuffer>;		) => Promise<ArrayBuffer>;
}		}

export default (TurboModuleRegistry.getEnforcing<Spec>(		export default (TurboModuleRegistry.getEnforcing<Spec>(
'CommTurboModule',		'CommTurboModule',
): Spec);		): Spec);

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.h

Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines	interface Spec extends TurboModule {
+getCurrentUserID: () => Promise<string>;		+getCurrentUserID: () => Promise<string>;
+setDeviceID: (deviceType: string) => Promise<string>;		+setDeviceID: (deviceType: string) => Promise<string>;
+getDeviceID: () => Promise<string>;		+getDeviceID: () => Promise<string>;
+clearSensitiveData: () => Promise<void>;		+clearSensitiveData: () => Promise<void>;
+checkIfDatabaseNeedsDeletion: () => boolean;		+checkIfDatabaseNeedsDeletion: () => boolean;
+reportDBOperationsFailure: () => void;		+reportDBOperationsFailure: () => void;
+computeBackupKey: (password: string, backupID: string) => Promise<Object>;		+computeBackupKey: (password: string, backupID: string) => Promise<Object>;
+generateRandomString: (size: number) => Promise<string>;		+generateRandomString: (size: number) => Promise<string>;
		+setCommServicesAccessToken: (accessToken: string) => Promise<void>;
		+getCommServicesAccessToken: () => Promise<string>;
		+clearCommServicesAccessToken: () => Promise<void>;
}		}

export interface CoreModuleSpec extends Spec {		export interface CoreModuleSpec extends Spec {
+computeBackupKey: (		+computeBackupKey: (
password: string,		password: string,
backupID: string,		backupID: string,
) => Promise<ArrayBuffer>;		) => Promise<ArrayBuffer>;
}		}

export default (TurboModuleRegistry.getEnforcing<Spec>(		export default (TurboModuleRegistry.getEnforcing<Spec>(
'CommTurboModule',		'CommTurboModule',
): Spec);		): Spec);