Differential D9909

[SQLite] add functions to convert user data and tests to user store methods
ClosedPublic
Actions

Authored by kamil on Nov 16 2023, 2:16 PM.

Details

Reviewers

tomek

Commits

rCOMMa6501a810620: [SQLite] add functions to convert user data and tests to user store methods

Summary

This tests both web and native logic.

Depends on D9904

Test Plan

Run tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 16 2023, 2:16 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 16 2023, 2:16 PM

kamil added a child revision: D9910: [SQLite] implement C++ user store ops.Nov 16 2023, 2:32 PM

kamil mentioned this in D9796: [lib] implement `UserStore` spec.Nov 16 2023, 2:45 PM

Harbormaster completed remote builds in B24200: Diff 33325.Nov 16 2023, 3:06 PM

kamil published this revision for review.Nov 16 2023, 3:06 PM

kamil mentioned this in D9904: [SQLite] add methods to operate on users table.

ashoat added inline comments.Nov 16 2023, 5:52 PM

web/database/queries/user-quries.test.js
34–35 ↗	(On Diff #33325)	New version of Flow will require types here. Can you add them?

tomek accepted this revision.Nov 17 2023, 3:27 PM

This revision is now accepted and ready to land.Nov 17 2023, 3:27 PM

improve Flow

Harbormaster completed remote builds in B24266: Diff 33404.Nov 20 2023, 12:20 PM

Closed by commit rCOMMa6501a810620: [SQLite] add functions to convert user data and tests to user store methods. · Explain WhyNov 20 2023, 1:48 PM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM5c36d95c18ad: [SQLite] add methods to operate on users table.

kamil added a commit: rCOMMa6501a810620: [SQLite] add functions to convert user data and tests to user store methods.

Revision Contents
Changeset List

Path

Size

lib/

ops/

user-store-ops.js

39 lines

web/

database/

queries/

user-quries.test.js

106 lines

Diff 33421

View Options

lib/ops/user-store-ops.js