Page MenuHomePhabricator

[native] Update existing checks on isDefault in role-panel-entry.react.js
ClosedPublic

Authored by atul on Nov 30 2023, 1:21 PM.
Tags
None
Referenced Files
F3573039: D10118.id37459.diff
Sat, Dec 28, 1:45 PM
F3573038: D10118.id37461.diff
Sat, Dec 28, 1:45 PM
F3573037: D10118.id34425.diff
Sat, Dec 28, 1:45 PM
F3573036: D10118.id34077.diff
Sat, Dec 28, 1:45 PM
F3573018: D10118.id.diff
Sat, Dec 28, 1:45 PM
Unknown Object (File)
Wed, Dec 18, 1:19 AM
Unknown Object (File)
Sun, Dec 1, 8:31 PM
Unknown Object (File)
Sun, Dec 1, 7:21 PM
Subscribers

Details

Summary

We now want to make sure that we get rid of checks on role.isDefault and replace them with checks on role.specialRole:

  • For default roles, this is `role.specialRole === ${specialRoles.DEFAULT_ROLE}
  • For admin roles, this is `role.specialRole === ${specialRoles.ADMIN_ROLE}

Part of ENG-5993

This diff handles role-panel-entry.react.js

Depends on D10117

Test Plan

Confirmed the use of roleIsDefaultRole had no change on the results in the code

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan held this revision as a draft.
rohan published this revision for review.Nov 30 2023, 1:34 PM
This revision is now accepted and ready to land.Dec 4 2023, 12:28 AM
atul edited reviewers, added: rohan; removed: atul.