[web] Updates to push notif service worker for unused-promise Flow lint
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:12 PM.

Details

Reviewers

michal
marcin

Commits

rCOMM3e606b5f18bf: [web] Updates to push notif service worker for unused-promise Flow lint

Summary

Two changes here:

Passing skipWaiting directly in self.addEventListener('install', skipWaiting). It looks like the types work for this.
Modifying the NotificationEvent.waitUntil call to wait until openWindow completes. I think the unused-promise Lint was helpful here in catching a case we should await, but would appreciate close review.

Depends on D10164

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 4 2023, 1:12 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 1:12 PM

ashoat added a child revision: D10166: [keyserver] Deprecate streamJSON.Dec 4 2023, 1:12 PM

Harbormaster completed remote builds in B24744: Diff 34207.Dec 4 2023, 2:36 PM

ashoat requested review of this revision.Dec 4 2023, 2:36 PM

@michal should have better context on whether client.openWindow should be awaited.

michal accepted this revision.Dec 5 2023, 2:52 AM

This revision is now accepted and ready to land.Dec 5 2023, 2:52 AM

Closed by commit rCOMM3e606b5f18bf: [web] Updates to push notif service worker for unused-promise Flow lint (authored by ashoat). · Explain WhyDec 5 2023, 12:32 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM3e606b5f18bf: [web] Updates to push notif service worker for unused-promise Flow lint.

Revision Contents
Changeset List

Path

Size

web/

push-notif/

service-worker.js

6 lines

Diff 34207

View Options

web/push-notif/service-worker.js

	// @flow			// @flow

	import * as React from 'react';			import * as React from 'react';

	import { assetMetaData } from './asset-meta-data.js';			import { assetMetaData } from './asset-meta-data.js';
	import HeroContent from './hero-content.react.js';			import HeroContent from './hero-content.react.js';
	import InfoBlock from './info-block.react.js';
	ginsuAuthorUnsubmitted Done Inline Actions Even though, there are currently no uses of `InfoBlock` we don't want to completely remove the component since the plan is to repurpose the component in a subsequent diff ginsu: Even though, there are currently no uses of `InfoBlock` we don't want to completely remove the…
	import css from './landing.css';			import css from './landing.css';
	import Picture from './Picture.react.js';			import Picture from './Picture.react.js';
	import usePreloadAssets from './use-pre-load-assets.react.js';			import usePreloadAssets from './use-pre-load-assets.react.js';

	function AppLanding(): React.Node {			function AppLanding(): React.Node {
	usePreloadAssets(assetMetaData);			usePreloadAssets(assetMetaData);
	const [			const [hero] = assetMetaData;
	hero,
	federated,
	customizable,
	encrypted,
	sovereign,
	openSource,
	lessNoisy,
	] = assetMetaData;

	return (			return (
	<main className={css.wrapper}>			<main className={css.wrapper}>
	<div className={hero.imageStyle}>			<div className={hero.imageStyle}>
	<Picture url={hero.url} alt={hero.alt} />			<Picture url={hero.url} alt={hero.alt} />
	</div>			</div>
	<HeroContent />			<HeroContent />
	<InfoBlock {...federated} />
	<InfoBlock {...customizable} />
	<InfoBlock {...encrypted} />
	<InfoBlock {...sovereign} />
	<InfoBlock {...openSource} />
	<InfoBlock {...lessNoisy} />
	</main>			</main>
	);			);
	}			}

	export default AppLanding;			export default AppLanding;

[web] Updates to push notif service worker for unused-promise Flow lintClosedPublicActions