Page MenuHomePhabricator

[web] Updates to push notif service worker for unused-promise Flow lint
ClosedPublic

Authored by ashoat on Dec 4 2023, 1:12 PM.
Tags
None
Referenced Files
F3343150: D10165.diff
Fri, Nov 22, 2:40 AM
Unknown Object (File)
Thu, Nov 7, 5:36 AM
Unknown Object (File)
Thu, Oct 24, 2:13 PM
Unknown Object (File)
Oct 22 2024, 3:38 AM
Unknown Object (File)
Oct 19 2024, 3:33 AM
Unknown Object (File)
Oct 16 2024, 7:32 AM
Unknown Object (File)
Oct 16 2024, 3:25 AM
Unknown Object (File)
Oct 16 2024, 3:25 AM
Subscribers

Details

Summary

Two changes here:

  1. Passing skipWaiting directly in self.addEventListener('install', skipWaiting). It looks like the types work for this.
  2. Modifying the NotificationEvent.waitUntil call to wait until openWindow completes. I think the unused-promise Lint was helpful here in catching a case we should await, but would appreciate close review.

Depends on D10164

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage