Page MenuHomePhabricator

[lib] Wrap spinPromises in ignorePromiseRejections
ClosedPublic

Authored by ashoat on Dec 4 2023, 1:09 PM.
Tags
None
Referenced Files
F3363528: D10161.id34203.diff
Mon, Nov 25, 2:26 AM
Unknown Object (File)
Wed, Nov 13, 7:34 AM
Unknown Object (File)
Thu, Nov 7, 8:35 PM
Unknown Object (File)
Oct 20 2024, 6:19 PM
Unknown Object (File)
Oct 16 2024, 10:31 PM
Unknown Object (File)
Oct 16 2024, 10:31 PM
Unknown Object (File)
Oct 16 2024, 10:30 PM
Unknown Object (File)
Oct 16 2024, 10:29 PM
Subscribers

Details

Summary

The unused-promise Flow lint revealed an issue here. We use SequentialPromiseResolver in keyserver, where an unhandled promise rejection could crash the whole server. But we aren't doing anything to handle a potential promise rejection here.

This diff wraps spinPromises in ignorePromiseRejections. This way, if the promise rejects we will print an error instead of crashing the whole keyserver.

Depends on D10160

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable