Page MenuHomePhabricator

[lib] Inline useBindCallKeyserverEndpointSelector
ClosedPublic

Authored by ashoat on Jan 17 2024, 9:12 PM.
Tags
None
Referenced Files
F3393916: D10687.id35823.diff
Sat, Nov 30, 4:27 PM
F3393693: D10687.diff
Sat, Nov 30, 3:45 PM
Unknown Object (File)
Wed, Nov 27, 11:51 PM
Unknown Object (File)
Wed, Nov 13, 6:14 AM
Unknown Object (File)
Wed, Nov 13, 6:13 AM
Unknown Object (File)
Thu, Nov 7, 10:45 AM
Unknown Object (File)
Tue, Nov 5, 5:49 PM
Unknown Object (File)
Oct 29 2024, 4:52 PM
Subscribers
None

Details

Summary

In a later diff we'll need to know the value of paramOverride from inside this code. I could pass it in as an additional argument, but I decided that reducing the indirection by inlining useBindCallKeyserverEndpointSelector would make the code more readable.

Additionally, the _memoize in useBindCallKeyserverEndpointSelector was not useful, so I removed it. Each call of useKeyserverCall will always pass in the same ActionFunc, so there's no need to keep a cache local to that invocation that is keyed on ActionFunc. The use of _memoize was left over from when I converted this from a global createSelector model, where it was useful. I should've removed it then.

Depends on D10686

Test Plan

I tested this stack using the following procedure:

  1. I tested primarily on native
    1. I compiled a dev build and deployed it to an iOS simulator
    2. I created a brand new account on my local keyserver using the iOS app
    3. I ran Redux dev tools: cd native && yarn redux-devtools
    4. I added a 30s sleep at the start of resolveKeyserverSessionInvalidation
    5. I made KeyserverConnectionsHandler return null so that the socket wouldn’t automatically recover the session prior to my testing
    6. I killed the app
    7. I deleted all of the test user’s cookie
    8. I then opened the app again and navigated to a chat and sent two messages
    9. By following the Redux monitor, I was able to see that the keyserver session invalidation recovery was successful, and both messages were eventually sent after the 30s sleep concluded
  2. On web, we don’t support keyserver session invalidation. However, I tested to make sure that the web app still loaded after my changes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable