Page MenuHomePhabricator
Differential D10774

[SQLite] add `keyservers` table for `KeyserverStore` data
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 3:43 AM.
Tags
None
Referenced Files
F3350083: D10774.id36254.diff
Fri, Nov 22, 8:39 PM
Unknown Object (File)
Wed, Nov 20, 10:32 PM
Unknown Object (File)
Fri, Nov 8, 8:14 PM
Unknown Object (File)
Wed, Nov 6, 6:48 PM
Unknown Object (File)
Oct 15 2024, 8:29 PM
Unknown Object (File)
Oct 15 2024, 7:57 AM
Unknown Object (File)
Oct 15 2024, 7:57 AM
Unknown Object (File)
Oct 15 2024, 7:57 AM
View All 37 Files
Subscribers
ashoat
inka
tomek

Details

Reviewers
inka
marcin
Commits
rCOMM640b14c1a919: [SQLite] add `keyservers` table for `KeyserverStore` data
Summary

Table to store data from KeyserverStore in SQLite.

Based on types defined in D10755.

Making table key-value (value is keyserver info in JSON) saves some implementation time and makes code more complicated. I discussed this with both @inka and @tomek and this should be enough - there is no need to make more columns (we can always migrate when there is any need).

Test Plan
  1. Test migration.
  2. Logout and test creating database from scratch.

Test on both web (it's visible in worker's logs) and native.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jan 22 2024, 3:43 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJan 22 2024, 3:43 AM
kamil added a child revision: D10775: [SQLite] add methods to operate on `keyservers` table.Jan 22 2024, 3:44 AM
Harbormaster failed remote builds in B26002: Diff 35934!Jan 22 2024, 4:00 AM
kamil updated this revision to Diff 35950.Jan 22 2024, 4:28 AM

rebase

Harbormaster completed remote builds in B26016: Diff 35950.Jan 22 2024, 4:53 AM
kamil published this revision for review.Jan 22 2024, 6:37 AM
kamil edited the summary of this revision. (Show Details)
inka accepted this revision.Jan 22 2024, 9:45 AM
This revision is now accepted and ready to land.Jan 22 2024, 9:45 AM
ashoat added a comment.Jan 23 2024, 8:48 AM

cc @marcin, who is working on refactoring our SQLite layer to no longer have sqlite_orm

marcin added a comment.Jan 23 2024, 9:11 AM
In D10774#311125, @ashoat wrote:

cc @marcin, who is working on refactoring our SQLite layer to no longer have sqlite_orm

This particular diff doesn't affect my work since ORM is not used here, but thanks for catching this!

Closed by commit rCOMM640b14c1a919: [SQLite] add `keyservers` table for `KeyserverStore` data (authored by kamil). · Explain WhyJan 29 2024, 3:49 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM640b14c1a919: [SQLite] add `keyservers` table for `KeyserverStore` data.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
17 lines
web/
database/
_generated/

Diff 35950

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/database/_generated/comm_query_executor.wasm

Loading...