Page MenuHomePhabricator

[identity] Refactor types for inbound/outbound keys
ClosedPublic

Authored by bartek on Jan 18 2024, 4:07 AM.
Tags
None
Referenced Files
F2902592: D10701.id36034.diff
Sat, Oct 5, 6:14 PM
Unknown Object (File)
Fri, Sep 20, 11:56 AM
Unknown Object (File)
Fri, Sep 6, 9:50 PM
Unknown Object (File)
Fri, Sep 6, 9:50 PM
Unknown Object (File)
Fri, Sep 6, 9:50 PM
Unknown Object (File)
Fri, Sep 6, 8:55 PM
Unknown Object (File)
Aug 28 2024, 11:46 PM
Unknown Object (File)
Aug 25 2024, 10:47 AM
Subscribers

Details

Summary

Part of ENG-5842.
Previous approach to passing inbound/outbound keys was using HashMaps of strings to strings. Also, with new device list, we were serializing these to hashmaps, just to parse them back a few lines later.
This was error prone and hard to maintain, so this diff introduces new, simplified and type-safe structs for inbound/outbound keys.

Also, removed the logic for checking social proof existence for each device, which turned out to be incorrect. The social proof is still checked when creating the EthereumIdentity response struct.

Depends on D10700

Test Plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.

Remove social proof check - see discussion linked in ENG-6479

bartek edited the test plan for this revision. (Show Details)
bartek removed 1 blocking reviewer(s): will.
bartek published this revision for review.Jan 19 2024, 3:19 AM
This revision is now accepted and ready to land.Jan 22 2024, 7:20 PM