Page MenuHomePhabricator
Differential D10844

[lib] Retry auth
ClosedPublic
Actions

Authored by tomek on Jan 26 2024, 9:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 10:18 AM
Unknown Object (File)
Feb 20 2025, 6:40 PM
Unknown Object (File)
Feb 19 2025, 10:21 AM
Unknown Object (File)
Feb 18 2025, 7:31 AM
Unknown Object (File)
Feb 10 2025, 12:00 AM
Unknown Object (File)
Feb 10 2025, 12:00 AM
Unknown Object (File)
Feb 9 2025, 6:37 PM
Unknown Object (File)
Feb 9 2025, 6:37 PM
View All 83 Files
Subscribers
ashoat

Details

Reviewers
varun
inka
kamil
Commits
rCOMM4111f6f08744: [lib] Retry auth
Summary

Retry the auth, if it wasn't successful, every 1 minute. We can change the delay if we think something else would work better.

Depends on D10843

Test Plan

Add a console log checking if unsuccessful auth is retried.

Diff Detail

Repository
rCOMM Comm
Branch
handlers-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jan 26 2024, 9:12 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 26 2024, 9:12 AM
Harbormaster completed remote builds in B26199: Diff 36187.Jan 26 2024, 9:44 AM
tomek requested review of this revision.Jan 26 2024, 9:44 AM
ashoat mentioned this in D10831: [lib] Run the keyserver auth only when it isn't running and a user isn't already authenticated.Jan 26 2024, 7:13 PM
ashoat added inline comments.
lib/components/keyserver-connection-handler.js
154–156

I think this is more readable

varun accepted this revision.Jan 29 2024, 7:54 PM
This revision is now accepted and ready to land.Jan 29 2024, 7:54 PM
tomek updated this revision to Diff 36347.Jan 30 2024, 8:21 AM
tomek marked an inline comment as done.

Use sleep

Harbormaster completed remote builds in B26299: Diff 36347.Jan 30 2024, 8:41 AM
tomek added a child revision: D10884: [lib] Cancel an auth every time dependencies change.Jan 31 2024, 7:29 AM
Closed by commit rCOMM4111f6f08744: [lib] Retry auth (authored by tomek). · Explain WhyFeb 5 2024, 7:23 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM4111f6f08744: [lib] Retry auth.

Revision Contents
Changeset List

PathSize
lib/
components/
14 lines

Diff 36187

View Options

lib/components/keyserver-connection-handler.js

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
}); });
type TooltipSize = { type TooltipSize = {
+height: number, +height: number,
+width: number, +width: number,
}; };
export type TooltipPositionStyle = { export type TooltipPositionStyle = {
+xCoord: number, +anchorPoint: {
+yCoord: number, +x: number,
+y: number,
},
+verticalPosition: 'top' | 'bottom', +verticalPosition: 'top' | 'bottom',
+horizontalPosition: 'left' | 'right', +horizontalPosition: 'left' | 'right',
+alignment: 'left' | 'center' | 'right', +alignment: 'left' | 'center' | 'right',
}; };
export type TooltipPosition = $Values<typeof tooltipPositions>; export type TooltipPosition = $Values<typeof tooltipPositions>;
export type MessageTooltipAction = { export type MessageTooltipAction = {
▲ Show 20 Lines • Show All 146 Lines • ▼ Show 20 Lines
function getMessageActionTooltipStyle({ function getMessageActionTooltipStyle({
sourcePositionInfo, sourcePositionInfo,
tooltipSize, tooltipSize,
tooltipPosition, tooltipPosition,
}: GetMessageActionTooltipStyleParams): TooltipPositionStyle { }: GetMessageActionTooltipStyleParams): TooltipPositionStyle {
if (tooltipPosition === tooltipPositions.RIGHT_TOP) { if (tooltipPosition === tooltipPositions.RIGHT_TOP) {
return { return {
xCoord: sourcePositionInfo.right, anchorPoint: {
yCoord: sourcePositionInfo.top, x: sourcePositionInfo.right,
y: sourcePositionInfo.top,
},
horizontalPosition: 'right', horizontalPosition: 'right',
verticalPosition: 'bottom', verticalPosition: 'bottom',
alignment: 'left', alignment: 'left',
}; };
} else if (tooltipPosition === tooltipPositions.LEFT_TOP) { } else if (tooltipPosition === tooltipPositions.LEFT_TOP) {
return { return {
xCoord: sourcePositionInfo.left, anchorPoint: {
yCoord: sourcePositionInfo.top, x: sourcePositionInfo.left,
y: sourcePositionInfo.top,
},
horizontalPosition: 'left', horizontalPosition: 'left',
verticalPosition: 'bottom', verticalPosition: 'bottom',
alignment: 'right', alignment: 'right',
}; };
} else if (tooltipPosition === tooltipPositions.RIGHT_BOTTOM) { } else if (tooltipPosition === tooltipPositions.RIGHT_BOTTOM) {
return { return {
xCoord: sourcePositionInfo.right, anchorPoint: {
yCoord: sourcePositionInfo.bottom, x: sourcePositionInfo.right,
y: sourcePositionInfo.bottom,
},
horizontalPosition: 'right', horizontalPosition: 'right',
verticalPosition: 'top', verticalPosition: 'top',
alignment: 'left', alignment: 'left',
}; };
} else if (tooltipPosition === tooltipPositions.LEFT_BOTTOM) { } else if (tooltipPosition === tooltipPositions.LEFT_BOTTOM) {
return { return {
xCoord: sourcePositionInfo.left, anchorPoint: {
yCoord: sourcePositionInfo.bottom, x: sourcePositionInfo.left,
y: sourcePositionInfo.bottom,
},
horizontalPosition: 'left', horizontalPosition: 'left',
verticalPosition: 'top', verticalPosition: 'top',
alignment: 'right', alignment: 'right',
}; };
} else if (tooltipPosition === tooltipPositions.LEFT) { } else if (tooltipPosition === tooltipPositions.LEFT) {
return { return {
xCoord: sourcePositionInfo.left, anchorPoint: {
yCoord: x: sourcePositionInfo.left,
y:
sourcePositionInfo.top + sourcePositionInfo.top +
sourcePositionInfo.height / 2 - sourcePositionInfo.height / 2 -
tooltipSize.height / 2, tooltipSize.height / 2,
},
horizontalPosition: 'left', horizontalPosition: 'left',
verticalPosition: 'bottom', verticalPosition: 'bottom',
alignment: 'right', alignment: 'right',
}; };
} else if (tooltipPosition === tooltipPositions.RIGHT) { } else if (tooltipPosition === tooltipPositions.RIGHT) {
return { return {
xCoord: sourcePositionInfo.right, anchorPoint: {
yCoord: x: sourcePositionInfo.right,
y:
sourcePositionInfo.top + sourcePositionInfo.top +
sourcePositionInfo.height / 2 - sourcePositionInfo.height / 2 -
tooltipSize.height / 2, tooltipSize.height / 2,
},
horizontalPosition: 'right', horizontalPosition: 'right',
verticalPosition: 'bottom', verticalPosition: 'bottom',
alignment: 'left', alignment: 'left',
}; };
} else if (tooltipPosition === tooltipPositions.TOP) { } else if (tooltipPosition === tooltipPositions.TOP) {
return { return {
xCoord: anchorPoint: {
x:
sourcePositionInfo.left + sourcePositionInfo.left +
sourcePositionInfo.width / 2 - sourcePositionInfo.width / 2 -
tooltipSize.width / 2, tooltipSize.width / 2,
yCoord: sourcePositionInfo.top, y: sourcePositionInfo.top,
},
horizontalPosition: 'right', horizontalPosition: 'right',
verticalPosition: 'top', verticalPosition: 'top',
alignment: 'center', alignment: 'center',
}; };
} else if (tooltipPosition === tooltipPositions.BOTTOM) { } else if (tooltipPosition === tooltipPositions.BOTTOM) {
return { return {
xCoord: anchorPoint: {
x:
sourcePositionInfo.left + sourcePositionInfo.left +
sourcePositionInfo.width / 2 - sourcePositionInfo.width / 2 -
tooltipSize.width / 2, tooltipSize.width / 2,
yCoord: sourcePositionInfo.bottom, y: sourcePositionInfo.bottom,
},
horizontalPosition: 'right', horizontalPosition: 'right',
verticalPosition: 'bottom', verticalPosition: 'bottom',
alignment: 'center', alignment: 'center',
}; };
} }
invariant(false, `Unexpected tooltip position value: ${tooltipPosition}`); invariant(false, `Unexpected tooltip position value: ${tooltipPosition}`);
} }
▲ Show 20 Lines • Show All 228 Lines • Show Last 20 Lines