Page MenuHomePhabricator

[lib] refactor connection-related actions in `keyserver-reducer` to ops
ClosedPublic

Authored by kamil on Jan 22 2024, 3:37 AM.
Tags
None
Referenced Files
F3377924: D10771.id36399.diff
Wed, Nov 27, 8:10 AM
Unknown Object (File)
Sat, Nov 23, 1:04 PM
Unknown Object (File)
Oct 28 2024, 12:03 AM
Unknown Object (File)
Oct 14 2024, 9:17 AM
Unknown Object (File)
Sep 28 2024, 2:24 PM
Unknown Object (File)
Sep 28 2024, 3:55 AM
Unknown Object (File)
Sep 28 2024, 3:55 AM
Unknown Object (File)
Sep 28 2024, 3:55 AM
Subscribers

Details

Summary

Convert logic to ops approach.

Depends on D10770

Test Plan

This is not that easy to test, and this sie basically copy-pasting approach from rest of the stack so this time just carefully reading the code.

EDIT: tested by dispatching following from redux dev-tools:

{
  type: 'SET_LATE_RESPONSE',
  payload: { messageID: '256|5', isLate: true, keyserverID: '256' }
}
{
  type: 'UPDATE_DISCONNECTED_BAR',
  payload: { visible: 'true', keyserverID: '256' }
}
{
  type: 'SET_CONNECTION_ISSUE',
  payload: { connectionIssue: null, keyserverID: '256' },
}

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.

Is there a reason this diff is a draft? (Maybe test plan)

kamil published this revision for review.Jan 27 2024, 9:31 AM
kamil edited the test plan for this revision. (Show Details)

Is there a reason this diff is a draft? (Maybe test plan)

yes, I wanted to check with @inka what is the best way to test it before publishing

This revision is now accepted and ready to land.Jan 30 2024, 1:47 AM