Paths

Table of Contentst

Differential D10773

[lib] refactor `reduceKeyserverStore` to return ops
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 3:42 AM.

Tags

None

Referenced Files

	F3378013: D10773.id36387.diff
	Wed, Nov 27, 8:35 AM

	Unknown Object (File)
	Sat, Nov 23, 3:58 PM

	Unknown Object (File)
	Sat, Nov 23, 2:36 PM

	Unknown Object (File)
	Sat, Nov 23, 12:20 PM

	Unknown Object (File)
	Wed, Nov 6, 4:18 PM

	Unknown Object (File)
	Oct 15 2024, 7:57 AM

	Unknown Object (File)
	Oct 15 2024, 7:57 AM

	Unknown Object (File)
	Oct 15 2024, 7:57 AM

View All 90 Files

Subscribers

Details

Reviewers

Commits

rCOMM4df683cd553b: [lib] refactor `reduceKeyserverStore` to return ops

Summary

Return ops to process in on DB later.

Test Plan

flow - just a refactor

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 22 2024, 3:42 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 3:42 AM

Harbormaster failed remote builds in B26001: Diff 35933!Jan 22 2024, 3:58 AM

rebase

Harbormaster completed remote builds in B26015: Diff 35949.Jan 22 2024, 4:48 AM

kamil added a child revision: D10784: [native][web] migrate keyservers to SQLite.Jan 22 2024, 5:52 AM

kamil published this revision for review.Jan 22 2024, 6:37 AM

inka accepted this revision.Jan 22 2024, 9:43 AM

This revision is now accepted and ready to land.Jan 22 2024, 9:43 AM

kamil mentioned this in D10755: [lib] implement `KeyserverStore` spec.Jan 27 2024, 8:18 AM

Hey @kamil, can you run arc diff for this diff again, so that it reflects the latest version of D10760? I want to arc patch this diff for my work in ENG-6856, but it's currently giving me an out-of-date version of D10760

kamil edited parent revisions, added: D10883: [lib] refactor deleting keyserver account `keyserver-reducer` to ops; removed: D10772: [lib] refactor setting device token in `keyserver-reducer` to ops.Jan 31 2024, 5:47 AM

rebase

kamil removed a parent revision: D10772: [lib] refactor setting device token in `keyserver-reducer` to ops.Jan 31 2024, 7:29 AM

Harbormaster completed remote builds in B26330: Diff 36383.Jan 31 2024, 7:46 AM

kamil edited the summary of this revision. (Show Details)Jan 31 2024, 8:05 AM

rebase

This revision was landed with ongoing or failed builds.Jan 31 2024, 8:23 AM

Closed by commit rCOMM4df683cd553b: [lib] refactor `reduceKeyserverStore` to return ops (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4df683cd553b: [lib] refactor `reduceKeyserverStore` to return ops.

Harbormaster completed remote builds in B26334: Diff 36387.Jan 31 2024, 8:24 AM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

keyserver-reducer.js

169 lines

keyserver-reducer.test.js

9 lines

master-reducer.js

2 lines

Diff 36401

lib/reducers/keyserver-reducer.js

Loading...

lib/reducers/keyserver-reducer.test.js

Loading...

lib/reducers/master-reducer.js

Loading...