This creates a search result type in shared and uses it in the identity search websocket server
Depends on 10848
Details
Details
Successfully tested on local dev. Prefix queries return correct response
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| shared/identity_search_messages/src/messages/search_result.rs | ||
|---|---|---|
| 15 ↗ | (On Diff #36200) | Not sure if convention dictates if payload should be a String. I can change this to another name like "results" or "hits" |
| shared/identity_search_messages/src/messages/search_result.rs | ||
|---|---|---|
| 6 ↗ | (On Diff #36200) | Should I tag this with its type? As in, should I put |
Comment Actions
Requesting because I think SearchResult should be added to the Messages enum. Correct me if I'm wrong
| shared/identity_search_messages/src/messages/mod.rs | ||
|---|---|---|
| 16 ↗ | (On Diff #36200) | Shouldn't you add this SearchResult to this enum? |
| shared/identity_search_messages/src/messages/search_result.rs | ||
| 6 ↗ | (On Diff #36200) | No, adding #[serde(tag = "type")] means that when you serialize/deserialize this, the JSON would add a field called type: { "type": "User", "userID": "foo", "username": "bar" } This makes sense e.g. for Tunnelbroker messages, when you have a big enum of various message types and thanks to the type field, it knows what message it is deserializing. There's no purpose of adding it here since User is only used as an inner type of SearchResult |
| 15 ↗ | (On Diff #36200) | The payload is probably Tunnelbroker-specific convention, so it's mostly up to you. |
| shared/identity_search_messages/src/messages/mod.rs | ||
|---|---|---|
| 16 ↗ | (On Diff #36200) | Originally, I had this removed as I'm utilizing Messages to deserialize client messages to server. However, I can just only match on AuthMessage, SearchQuery, and Heartbeat. Will add SearchResult |
| shared/identity_search_messages/src/messages/search_result.rs | ||
|---|---|---|
| 15 ↗ | (On Diff #36200) | Got it. I'll go with "hits" then as it is more specific to identity search. |
| shared/identity_search_messages/src/messages/mod.rs | ||
|---|---|---|
| 16 ↗ | (On Diff #36200) |
Yeah, so adding this adds possibility to deserialize server messages on clients too ;)
Exactly, you can always match all unrelated types with _ => Err(unexpected message) |