Details
Details
- Enabled encrypted media and blob service, sent a multimedia message
- Modified blob handlers the same way as in D10908 test plan
- Opened chat on native - the multimedia loads correctly, blob service logs contain auth metadata:
INFO get_blob{blob_hash=xn2ILjHR45XHsbjNf_wRalWNjusWtCNntiutX1eJn0w}: blob::http::handlers::blob: Get blob request auth=UserToken(UserIdentity { user_id: "foo", access_token: "baz", device_id: "9/Dk+21eU27n7fpvFDVWqNrouje2XKGW2jtLPC7vx+A" })
`Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/utils/services-utils.js | ||
|---|---|---|
| 25 | Same as in https://phab.comm.dev/D10908?id=36504#inline-66206 | |
| native/media/save-media.js | ||
| 381 | This place is too deeply nested function so it's not worth passing-through value from identity context 5 functions above. I think it's OK to get it directly from SecureStore here. | |
| native/media/save-media.js | ||
|---|---|---|
| 381 | You can consider introducing a hook that uses IdentityClientContext and returns a callback saveRemoteMediaToDisk. It might also make sense for fetchAndDecryptMedia because it always requires auth headers. | |
| native/media/save-media.js | ||
|---|---|---|
| 381 | Yes, it makes sense for fetchAndDecryptMedia in other places, but in this case, this won't solve my initial issue - I still need to pass the callback 5 levels down which, in my opinion, is not worth it. | |