Page MenuHomePhabricator

[lib] introduce barebones community types
ClosedPublic

Authored by ginsu on Feb 12 2024, 2:24 AM.
Tags
None
Referenced Files
F3376381: D11036.diff
Tue, Nov 26, 11:40 PM
Unknown Object (File)
Thu, Nov 7, 11:27 PM
Unknown Object (File)
Wed, Nov 6, 3:24 PM
Unknown Object (File)
Oct 14 2024, 7:05 PM
Unknown Object (File)
Oct 14 2024, 7:05 PM
Unknown Object (File)
Oct 14 2024, 7:05 PM
Unknown Object (File)
Oct 14 2024, 7:04 PM
Unknown Object (File)
Oct 14 2024, 7:04 PM
Subscribers

Details

Summary

This diff introduces the barebones community types that will be used to build the community store. To keep things as simple as possible, I am just includinng the enabledApps since this will be needed for the web app redesign; however, I can imagine us wanting to extend this in the future when we build more community based features out

Linear task: https://linear.app/comm/issue/ENG-6157/introduce-community-types

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu added reviewers: atul, kamil, inka.
ginsu requested review of this revision.Feb 12 2024, 2:39 AM
atul added inline comments.
lib/types/community-types.js
9 ↗(On Diff #36989)

Instead of key can you do threadID to avoid including this comment?

Something like:

960170.png (186×1 px, 61 KB)

This revision is now accepted and ready to land.Feb 12 2024, 1:07 PM
This revision was landed with ongoing or failed builds.Feb 13 2024, 11:20 AM
This revision was automatically updated to reflect the committed changes.