[native] use identity wallet registration from final step of new registration workflow
ClosedPublic
Actions

Authored by varun on Feb 9 2024, 10:41 AM.

Details

Reviewers

ashoat
inka
tomek

Commits

rCOMMce88c7faa07c: [native] use identity wallet registration from final step of new registration…

Summary

if usingCommServicesAccessToken, use identity wallet registration RPC for auth

Test Plan

confirmed that the action was dispatched successfully, verified that payload contents in redux matched local ddb

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Feb 9 2024, 10:41 AM

varun added a child revision: D11018: [web] prefix legacy getSIWENonce/siweAuth logic with "legacy".

Harbormaster completed remote builds in B26720: Diff 36946.Feb 9 2024, 10:56 AM

varun requested review of this revision.Feb 9 2024, 10:56 AM

ashoat accepted this revision.Feb 9 2024, 11:22 AM

This revision is now accepted and ready to land.Feb 9 2024, 11:22 AM

varun edited parent revisions, added: D11100: [native] call identity wallet login from ExistingEthereumAccount; removed: D11016: [native] logic for navigating to ExistingEthereumAccount if usingCommServicesAccessToken.Feb 15 2024, 8:38 PM

varun retitled this revision from [native] use identity wallet login from final step of new registration workflow to [native] use identity wallet registration from final step of new registration workflow.

varun edited the summary of this revision. (Show Details)

varun added a parent revision: D11016: [native] logic for navigating to ExistingEthereumAccount if usingCommServicesAccessToken.

use identity wallet registration RPC

varun removed a parent revision: D11016: [native] logic for navigating to ExistingEthereumAccount if usingCommServicesAccessToken.Feb 15 2024, 8:40 PM

varun edited the summary of this revision. (Show Details)

varun added a parent revision: D11016: [native] logic for navigating to ExistingEthereumAccount if usingCommServicesAccessToken.

Harbormaster completed remote builds in B26947: Diff 37290.Feb 15 2024, 8:54 PM

varun edited the summary of this revision. (Show Details)Feb 16 2024, 7:01 AM

varun removed a parent revision: D11016: [native] logic for navigating to ExistingEthereumAccount if usingCommServicesAccessToken.

We had talked previously about falling back to the legacy APIs if the new ones were broken or failing for whatever reason. Is that still the plan? It looks like this code doesn't have a fallback mechanism like that

In D11017#320732, @ashoat wrote:

We had talked previously about falling back to the legacy APIs if the new ones were broken or failing for whatever reason. Is that still the plan? It looks like this code doesn't have a fallback mechanism like that

new plan is described in this comment: https://linear.app/comm/issue/ENG-6881/fallback-mechanism-for-login-and-registration#comment-9445e916

Closed by commit rCOMMce88c7faa07c: [native] use identity wallet registration from final step of new registration… (authored by varun). · Explain WhyFeb 22 2024, 8:17 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMce88c7faa07c: [native] use identity wallet registration from final step of new registration….