Page MenuHomePhabricator
Differential D11109

[native][web] implementing uploading one-time keys in `IdentityServiceClient`
ClosedPublic
Actions

Authored by kamil on Feb 19 2024, 8:12 AM.
Tags
None
Referenced Files
F3347134: D11109.diff
Fri, Nov 22, 11:12 AM
Unknown Object (File)
Wed, Nov 13, 4:09 AM
Unknown Object (File)
Wed, Nov 13, 4:09 AM
Unknown Object (File)
Wed, Nov 13, 4:09 AM
Unknown Object (File)
Tue, Nov 12, 8:55 PM
Unknown Object (File)
Oct 10 2024, 9:57 AM
Unknown Object (File)
Oct 10 2024, 9:56 AM
Unknown Object (File)
Oct 10 2024, 9:56 AM
View All 56 Files
Subscribers
ashoat

Details

Reviewers
marcin
varun
tomek
Commits
rCOMM65369defbe28: [native][web] implementing uploading one-time keys in `IdentityServiceClient`
Summary

Call RPC to upload keys to Identity.

Depends on D11108

Test Plan

Call this method and check in staging DDB that one-time key was uploaded.

await identityClient.uploadOneTimeKeys({
        contentOneTimeKeys: ['test1'],
        notificationsOneTimeKeys: ['test2'],
      })

Screenshot 2024-02-19 at 13.08.59.png (1×1 px, 283 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Feb 19 2024, 8:12 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 19 2024, 8:12 AM
kamil edited the test plan for this revision. (Show Details)Feb 19 2024, 8:13 AM
Harbormaster completed remote builds in B26969: Diff 37328.Feb 19 2024, 8:27 AM
kamil added a child revision: D11110: [web] implementing publishing prekeys to Identity.Feb 19 2024, 8:28 AM
kamil published this revision for review.Feb 19 2024, 9:36 AM
ashoat added a comment.Feb 19 2024, 7:44 PM

Is marking as published handled separately?

tomek accepted this revision.Feb 21 2024, 1:57 AM
This revision is now accepted and ready to land.Feb 21 2024, 1:57 AM
kamil added a comment.Feb 22 2024, 8:05 AM
In D11109#321001, @ashoat wrote:

Is marking as published handled separately?

Yes, in D11109

ashoat added a comment.Feb 22 2024, 10:37 AM

I think you linked the wrong diff (you linked this one)

kamil added a comment.Feb 23 2024, 1:26 AM
In D11109#321883, @ashoat wrote:

I think you linked the wrong diff (you linked this one)

ahh right - D11119

Closed by commit rCOMM65369defbe28: [native][web] implementing uploading one-time keys in `IdentityServiceClient` (authored by kamil). · Explain WhyFeb 23 2024, 1:32 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM65369defbe28: [native][web] implementing uploading one-time keys in `IdentityServiceClient`.

Revision Contents
Changeset List

PathSize
lib/
types/
5 lines
2 lines
native/
identity-service/
16 lines
web/
grpc/
17 lines

Diff 37486

View Options

lib/types/crypto-types.js

Loading...
View Options

lib/types/identity-service-types.js

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

web/grpc/identity-service-client-wrapper.js

Loading...