Page MenuHomePhabricator

[identity] validate origins provided through env var
ClosedPublic

Authored by varun on Mar 5 2024, 3:21 PM.
Tags
None
Referenced Files
F3115320: D11250.id37867.diff
Thu, Oct 31, 9:26 PM
Unknown Object (File)
Thu, Oct 10, 12:16 PM
Unknown Object (File)
Thu, Oct 10, 12:16 PM
Unknown Object (File)
Thu, Oct 10, 12:15 PM
Unknown Object (File)
Thu, Oct 10, 11:33 AM
Unknown Object (File)
Sep 19 2024, 1:19 PM
Unknown Object (File)
Sep 19 2024, 1:09 PM
Unknown Object (File)
Sep 19 2024, 6:00 AM
Subscribers

Details

Summary

quick follow up to ENG-6926. the HeaderValue::from_str function takes pretty much any ascii string, but we should validate these strings first to make sure we have the right format in terraform, where we set the value of ALLOW_ORIGIN_LIST

we already use the url crate in shared/backup_client and services/commtest

Test Plan

unit tests, tested that other schemes like ftp and missing ports don't work on staging

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage