ENG-6648 : Refactor database worker
The database worker will now contains code not related to the database (e.g. cryptoStore and other crypto related operations) so I'm renaming it to a general shared-worker.
Depends on D11143
Details
Details
- Reviewers
kamil tomek - Commits
- rCOMM6d5574c4eb8f: [web] Rename database worker
Check that the app works, click around, check that the database works.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Are you sure this change is fully backward compatible? Looks like yes but want to confirm
| web/app.react.js | ||
|---|---|---|
| 123 ↗ | (On Diff #37782) | |
Comment Actions
Fixed comment. Also renamed the worker name from comm-app-database-${codeVersion} to comm-app-shared-worker-${codeVersion}.
Are you sure this change is fully backward compatible? Looks like yes but want to confirm
I don't think we expose the shared worker to e.g. keyserver. It should be fully an "implementation detail" for the webapp codebase (except for the moment when the app loads the worker code at the start). If there are multiple tabs open the mismatch will be handled like the version mismatch -> the workers have different names so they shouldn't collide.