Page MenuHomePhabricator

[web/native] Add signMessage to olmAPI
ClosedPublic

Authored by michal on Mar 26 2024, 7:02 AM.
Tags
None
Referenced Files
F3363850: D11386.id38328.diff
Mon, Nov 25, 3:28 AM
Unknown Object (File)
Wed, Nov 13, 6:09 PM
Unknown Object (File)
Wed, Nov 6, 2:56 PM
Unknown Object (File)
Thu, Oct 31, 6:03 PM
Unknown Object (File)
Oct 15 2024, 2:34 PM
Unknown Object (File)
Oct 15 2024, 2:34 PM
Unknown Object (File)
Oct 15 2024, 2:34 PM
Unknown Object (File)
Oct 15 2024, 2:34 PM
Subscribers

Details

Summary

After rebasing the stack on master now both web and native started using the olm methods to sign messages. Because of that this diff introduces a new method to olmAPI -> signMessage. On native it's just an alias for commCoreModule implementation and on web it proxies to a simple signing function on worker.

Depends on D11373

Test Plan

Called olmApi.signMessage on native. Exported the pickled cryptostore from native and imported it on web. Called olmApi.signMessage on web. Made sure that the outputs matched (for the same input).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil added inline comments.
native/qr-code/qr-code-screen.react.js
63 ↗(On Diff #38328)

shouldn't you update also web/account/qr-code-login.react.js?

This revision is now accepted and ready to land.Mar 27 2024, 12:27 AM
native/qr-code/qr-code-screen.react.js
63 ↗(On Diff #38328)

This is done D11348 as it required some bigger changes and not just a swap, like on native.