Introduce user texts for siwe backup message creation
ClosedPublic
Actions

Authored by marcin on Apr 11 2024, 8:56 AM.

Details

Reviewers

ashoat
atul

Commits

Summary

This differential introduces constants with user texts that will be displayed during backup message generation.

Test Plan

N/A

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Adding @ashoat as a reviewer since this diff introduces text displayed to the user.

marcin requested review of this revision.Apr 11 2024, 9:12 AM

atul added inline comments.

lib/utils/siwe-utils.js
120–123 ↗	(On Diff #39058)	Has this copy been signed off on? Is it from white paper? Feel like it should be something like "Signing this will create backup key for your Comm account"?

This revision is now accepted and ready to land.Apr 11 2024, 12:23 PM

lib/utils/siwe-utils.js
120–123 ↗	(On Diff #39058)	I don't believe this has been signed off on. @marcin, note that I need to approve all new copy, even if it's in Figma. Copy in Figma has not be pre-approved. Let's go with this: Your signature on this message will be used to derive a secret key that will encrypt your Comm backup.

Seeing now that @marcin added me for approval:

Adding @ashoat as a reviewer since this diff introduces text displayed to the user.

In the future, it's a good idea to set me as a blocking reviewer in this case, so the diff isn't considered accepted until I review it.

lib/utils/siwe-utils.js
120–123 ↗	(On Diff #39058)	Those texts don't come from whitepaper - they come from Figma: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?type=design&node-id=11617-293984&mode=design&t=kZlddBvG5d3ZbRFk-0.