Paths

Table of Contentst

Differential D11733

Update latest backup id search index to include 'msgBackup'
ClosedPublic
Actions

Authored by marcin on Apr 23 2024, 3:48 AM.

Tags

None

Referenced Files

	F3556781: D11733.id39390.diff
	Thu, Dec 26, 11:50 PM

	F3556698: D11733.id40013.diff
	Thu, Dec 26, 11:47 PM

	F3555815: D11733.id40002.diff
	Thu, Dec 26, 11:26 PM

	F3543073: D11733.diff
	Thu, Dec 26, 9:26 AM

	Unknown Object (File)
	Sun, Dec 22, 12:25 AM

	Unknown Object (File)
	Sun, Dec 22, 12:25 AM

	Unknown Object (File)
	Sun, Dec 22, 12:25 AM

	Unknown Object (File)
	Sun, Dec 22, 12:25 AM

View All 70 Files

Subscribers

Details

Reviewers

bartek
kamil

Commits

rCOMMb5133e10780b: Update latest backup id search index to include 'msgBackup'

Summary

This differential updatest backup table dynamodb schema. Without this change I was unable to get backup messages from dynamodb back even though I was able to put them
in the db. My understanding is that when fetching latest backup item we use index that previously wasn't aware of msg_backup field.

Test Plan

run terraform fmt and validate.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Apr 23 2024, 3:48 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 23 2024, 3:48 AM

marcin added a parent revision: D11716: Enable backup creation and upload for SIWE users from JS.Apr 23 2024, 3:49 AM

marcin added a child revision: D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.Apr 23 2024, 3:52 AM

Harbormaster completed remote builds in B28395: Diff 39390.Apr 23 2024, 4:04 AM

marcin requested review of this revision.Apr 23 2024, 4:04 AM

Looks good, let me know when you'll be landing this, so we can do terraform apply together

services/terraform/modules/shared/dynamodb.tf
27	Technically doesn't matter, but consider my comment in https://phab.comm.dev/D11713#inline-70321

This revision is now accepted and ready to land.Apr 24 2024, 2:00 AM

Rename msgBackup to siweBackupMsg

Harbormaster completed remote builds in B28505: Diff 39540.Apr 26 2024, 6:50 AM

Rebase before landing

Harbormaster completed remote builds in B28801: Diff 40002.May 9 2024, 6:45 AM

Closed by commit rCOMMb5133e10780b: Update latest backup id search index to include 'msgBackup' (authored by marcin). · Explain WhyMay 9 2024, 7:00 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMb5133e10780b: Update latest backup id search index to include 'msgBackup'.

Revision Contents
Changeset List

Path

Size

services/

terraform/

modules/

shared/

2 lines

Diff 39390

services/terraform/modules/shared/dynamodb.tf

Loading...