[lib] Simplify `threadMemberHasPermission()`
ClosedPublic
Actions

Authored by atul on Apr 23 2024, 10:46 AM.

Details

Reviewers

ginsu
tomek
varun
will

Commits

rCOMM24c5c5fc270d: [lib] Simplify `threadMemberHasPermission()`

Summary

This function is only consumed by appendUserInfo which is only consumed in usePotentialMemberItems. This hook is only used on client, so there's no need to support Server* or Legacy* types.

We can also skip .minimallyEncoded branch since all clients work exclusively with MinimallyEncoded* types at this point.

Depends on D11740

Test Plan

NA, flow and read through callsites.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 23 2024, 10:46 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 23 2024, 10:46 AM

atul added a child revision: D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.Apr 23 2024, 10:55 AM

Harbormaster completed remote builds in B28412: Diff 39417.Apr 23 2024, 11:09 AM

atul requested review of this revision.Apr 23 2024, 11:09 AM

tomek accepted this revision.Apr 24 2024, 4:25 AM

This revision is now accepted and ready to land.Apr 24 2024, 4:25 AM

land trivial

This revision was landed with ongoing or failed builds.Apr 24 2024, 12:23 PM

Closed by commit rCOMM24c5c5fc270d: [lib] Simplify `threadMemberHasPermission()` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM24c5c5fc270d: [lib] Simplify `threadMemberHasPermission()`.

Harbormaster completed remote builds in B28435: Diff 39443.Apr 24 2024, 12:31 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

11 lines

Diff 39417

View Options

lib/shared/thread-utils.js

[lib] Simplify `threadMemberHasPermission()`ClosedPublicActions