[lib] Simplify `threadMemberHasPermission()`
ClosedPublic
Actions

Authored by atul on Apr 23 2024, 10:46 AM.

Details

Reviewers

ginsu
tomek
varun
will

Commits

rCOMM24c5c5fc270d: [lib] Simplify `threadMemberHasPermission()`

Summary

This function is only consumed by appendUserInfo which is only consumed in usePotentialMemberItems. This hook is only used on client, so there's no need to support Server* or Legacy* types.

We can also skip .minimallyEncoded branch since all clients work exclusively with MinimallyEncoded* types at this point.

Depends on D11740

Test Plan

NA, flow and read through callsites.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D11741 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 23 2024, 10:46 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 23 2024, 10:46 AM

atul added a child revision: D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.Apr 23 2024, 10:55 AM

Harbormaster completed remote builds in B28412: Diff 39417.Apr 23 2024, 11:09 AM

atul requested review of this revision.Apr 23 2024, 11:09 AM

tomek accepted this revision.Apr 24 2024, 4:25 AM

This revision is now accepted and ready to land.Apr 24 2024, 4:25 AM

land trivial

This revision was landed with ongoing or failed builds.Apr 24 2024, 12:23 PM

Closed by commit rCOMM24c5c5fc270d: [lib] Simplify `threadMemberHasPermission()` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM24c5c5fc270d: [lib] Simplify `threadMemberHasPermission()`.

Harbormaster completed remote builds in B28435: Diff 39443.Apr 24 2024, 12:31 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

11 lines

Diff 39443

View Options

lib/shared/thread-utils.js

This file was added.

				#import "CommServicesAuthMetadataEmitter.h"

				#import <Foundation/Foundation.h>
				#import <React/RCTBridgeModule.h>
				#import <React/RCTEventEmitter.h>

				NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";

				@interface CommServicesAuthMetadataEmitterIOSWrapper
				marcinAuthorUnsubmitted Done Inline Actions It might look uncommon to have interface declaration and implementation next to each other in a single file but in fact we don't need to expose `CommServicesAuthMetadataIOSWrapper`. If we want to call `sendAuthMetadataToJS` from Objective - C we can use the common C++ API so let's avoid creating unnecessary files and duplication the same API. marcin: It might look uncommon to have interface declaration and implementation next to each other in a…
				bartekUnsubmitted Not Done Inline Actions It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes sense here bartek: It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes…
				: RCTEventEmitter <RCTBridgeModule>
				@property(nonatomic) BOOL hasListeners;

				+ (void)sendToJSAccessToken:(NSString *)accessToken
				withUserID:(NSString *)userID
				withDeviceID:(NSString *)deviceID;
				bartekUnsubmitted Not Done Inline Actions What about `sendAccessTokenToJS: ... withUserID: ... withDeviceID`? Initially, I got confused because I understood `sendToJSAccessToken` as "send something to JS-based access token" 😅 bartek: What about `sendAccessTokenToJS: ... withUserID: ... withDeviceID`? Initially, I got confused…
				varunUnsubmitted Not Done Inline Actions +1 varun: +1
				@end

				@implementation CommServicesAuthMetadataEmitterIOSWrapper

				RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);

				static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;

				- (instancetype)init {
				self = [super init];
				if (!self) {
				return self;
				}
				_hasListeners = NO;
				return self;
				}

				- (void)startObserving {
				@synchronized([self class]) {
				_hasListeners = YES;
				sharedInstance = self;
				}
				}

				- (void)stopObserving {
				@synchronized([self class]) {
				_hasListeners = NO;
				sharedInstance = nil;
				}
				}

				- (NSArray<NSString > )supportedEvents {
				return @[ commServicesAuthMetadata ];
				}

				- (NSDictionary *)constantsToExport {
				return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
				}

				+ (BOOL)requiresMainQueueSetup {
				return YES;
				}

				+ (void)sendToJSAccessToken:(NSString *)accessToken
				withUserID:(NSString *)userID
				withDeviceID:(NSString *)deviceID {
				@synchronized([self class]) {
				if (!sharedInstance) {
				return;
				}

				NSDictionary *eventBody = @{
				@"accessToken" : accessToken,
				@"userID" : userID,
				@"deviceID" : deviceID
				};

				[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
				}
				}

				@end

				namespace comm {

				void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
				rust::String accessToken,
				rust::String userID,
				rust::String deviceID) {
				NSString *accessTokenObjC =
				[NSString stringWithCString:std::string(accessToken).c_str()
				encoding:NSUTF8StringEncoding];
				NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
				encoding:NSUTF8StringEncoding];
				NSString *deviceIDObjC =
				[NSString stringWithCString:std::string(deviceID).c_str()
				encoding:NSUTF8StringEncoding];

				[CommServicesAuthMetadataEmitterIOSWrapper sendToJSAccessToken:accessTokenObjC
				withUserID:userIDObjC
				withDeviceID:deviceIDObjC];
				}
				} // namespace comm

[lib] Simplify `threadMemberHasPermission()`ClosedPublicActions