[web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`
ClosedPublic
Actions

Authored by atul on Apr 23 2024, 12:45 PM.

Details

Reviewers

ginsu
tomek
varun
will

Commits

rCOMM9f41d12aef51: [web] Replace `threadHasPermission` with `useThreadHasPermission` in…

Summary

Followup to D11746 where we're updating client to use hook.

Depends on D11746

Test Plan

flow/CI/etc.

Thread where I shouldn't have EDIT_THREAD_AVATAR permission doesn't let me change avatar:

Thread where I should have EDIT_THREAD_AVATAR permission DOES let me change avatar:

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 23 2024, 12:45 PM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 23 2024, 12:45 PM

I was going to do one big diff that updated everything in web, then native, etc... but there are some slight additional changes being made to these components (changing of Prop types, dep lists, etc) so figured it might be safe to break each into a separate diff even if it's spammy? Can change approach if preferred, but going off feedback from https://phab.comm.dev/D9907

Harbormaster completed remote builds in B28419: Diff 39424.Apr 23 2024, 1:07 PM

atul requested review of this revision.Apr 23 2024, 1:07 PM

atul added a child revision: D11748: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.Apr 23 2024, 1:17 PM

tomek accepted this revision.Apr 24 2024, 4:39 AM

This revision is now accepted and ready to land.Apr 24 2024, 4:39 AM

I think you should consider having a test plan that actually verifies that this logic is correct.

In D11747#337401, @tomek wrote:

I think you should consider having a test plan that actually verifies that this logic is correct.

Added Test Plan for this diff and did some console logging as sanity check for subsequent diffs, but think it's unnecessary to do a full blown Test Plan for diffs in this stack since changes are pretty straightforward

atul edited the test plan for this revision. (Show Details)Apr 24 2024, 1:18 PM

land

Harbormaster completed remote builds in B28450: Diff 39461.Apr 24 2024, 1:51 PM

Closed by commit rCOMM9f41d12aef51: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul). · Explain WhyApr 24 2024, 6:58 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM9f41d12aef51: [web] Replace `threadHasPermission` with `useThreadHasPermission` in….