Page MenuHomePhabricator
Differential D12074

[SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`
ClosedPublic
Actions

Authored by kamil on May 16 2024, 7:14 AM.
Tags
None
Referenced Files
F3346431: D12074.diff
Fri, Nov 22, 8:46 AM
Unknown Object (File)
Thu, Nov 7, 5:00 PM
Unknown Object (File)
Oct 14 2024, 4:58 PM
Unknown Object (File)
Oct 14 2024, 4:58 PM
Unknown Object (File)
Oct 14 2024, 4:57 PM
Unknown Object (File)
Sep 4 2024, 4:18 AM
Unknown Object (File)
Sep 4 2024, 4:18 AM
Unknown Object (File)
Sep 4 2024, 4:18 AM
View All 36 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMMdcb171a7b9fa: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`
Summary

After processing the other peer will send only messageID - not full OutboundP2PMessage.

Depends on D12071

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Branch
publish-broadcasting
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 16 2024, 7:14 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMay 16 2024, 7:14 AM
Harbormaster completed remote builds in B28985: Diff 40289.May 16 2024, 7:29 AM
kamil added a child revision: D12075: [SQLite] remove `deviceID` param when getting all Outbound P2P messages.May 16 2024, 7:33 AM
kamil added inline comments.May 16 2024, 10:11 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1149

debugging leftover

kamil published this revision for review.May 17 2024, 3:23 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2149–2152

not sure about indentation here

marcin added inline comments.May 17 2024, 6:28 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2149–2152

The convention is to sue the same SQL formatting conventions as we have on the keyserver. Take a look here: https://github.com/CommE2E/comm/blob/master/keyserver/src/creators/invite-link-creator.js#L158-L164

2159–2161

Please use SQLiteDataConverters.h

2164–2169

You can remove those lines - SQLiteStatementWrapper destructor does it automatically.

kamil updated this revision to Diff 40588.May 23 2024, 8:26 AM

address review

Harbormaster completed remote builds in B29215: Diff 40588.May 23 2024, 8:42 AM
marcin accepted this revision.May 23 2024, 8:42 AM
This revision is now accepted and ready to land.May 23 2024, 8:42 AM
Closed by commit rCOMMdcb171a7b9fa: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID` (authored by kamil). · Explain WhyMay 23 2024, 9:02 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMdcb171a7b9fa: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
3 lines
3 lines
21 lines
web/
shared-worker/
_generated/
queries/
11 lines
types/
3 lines

Diff 40289

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...