Page MenuHomePhabricator
Differential D12150

[lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly` required
ClosedPublic
Actions

Authored by atul on May 21 2024, 8:04 AM.
Tags
None
Referenced Files
F3354274: D12150.id40770.diff
Sat, Nov 23, 12:41 PM
F3354052: D12150.id40769.diff
Sat, Nov 23, 11:38 AM
Unknown Object (File)
Sat, Nov 9, 5:12 AM
Unknown Object (File)
Oct 23 2024, 8:18 PM
Unknown Object (File)
Oct 23 2024, 4:47 AM
Unknown Object (File)
Oct 22 2024, 5:45 PM
Unknown Object (File)
Oct 19 2024, 5:32 PM
Unknown Object (File)
Oct 19 2024, 4:54 PM
View All 68 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Commits
rCOMMe31838429e78: [lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly`…
Summary

I want to add another skipMemberAdminRoleCheck argument to this function. Can't have two optional arguments, so going to make them both required.

Only two callsites to threadIsWithBlockedUserOnly and they're pretty straightforward.

Depends on D12149

Test Plan

Trusting flow here.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 21 2024, 8:04 AM
atul published this revision for review.May 21 2024, 8:04 AM
atul added a child revision: D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.May 21 2024, 8:27 AM
Harbormaster completed remote builds in B29113: Diff 40480.May 21 2024, 8:50 AM
varun resigned from this revision.May 22 2024, 7:41 AM

i'm probably not a good reviewer of this code

ashoat accepted this revision.May 24 2024, 2:51 AM
This revision is now accepted and ready to land.May 24 2024, 2:51 AM
atul updated this revision to Diff 40769.May 29 2024, 10:24 PM

rebase

atul updated this revision to Diff 40770.May 29 2024, 10:27 PM

ready to land

This revision was landed with ongoing or failed builds.May 29 2024, 10:35 PM
Closed by commit rCOMMe31838429e78: [lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly`… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMe31838429e78: [lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly`….
Harbormaster completed remote builds in B29299: Diff 40769.May 29 2024, 10:41 PM
Harbormaster completed remote builds in B29300: Diff 40770.May 29 2024, 10:46 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
4 lines

Diff 40480

View Options

lib/shared/thread-utils.js

Loading...