Page MenuHomePhabricator

[native] Inline siweButton in LoggedOutModal
ClosedPublic

Authored by ashoat on May 22 2024, 7:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 10, 4:22 AM
Unknown Object (File)
Thu, Jan 9, 12:20 AM
Unknown Object (File)
Tue, Jan 7, 12:21 AM
Unknown Object (File)
Fri, Jan 3, 3:13 AM
Unknown Object (File)
Wed, Jan 1, 2:50 AM
Unknown Object (File)
Fri, Dec 20, 6:06 AM
Unknown Object (File)
Mon, Dec 16, 6:19 PM
Unknown Object (File)
Mon, Dec 16, 6:19 PM
Subscribers

Details

Summary

As a first step towards replacing the Reanimated 1 syntax in LoggedOutModal with Reanimated 2 syntax (ENG-8146), I'm converting the class component to a function component.

Not clear why this was defined separately. Maybe it was used in multiple places previously?

Doing this as a separate diff because it's a simple move, to make later diffs easier to review.

Depends on D12192

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

  1. I navigated to LogInPanel and back
  2. I navigated to LegacyRegisterPanel and back
  3. I navigated to FullscreenSIWEPanel and back
  4. I navigated to QRCodeSignInNavigator and back
  5. I navigated to Registration and back

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable