Page MenuHomePhabricator
Differential D12247

[sqlite] create message store local table
ClosedPublic
Actions

Authored by will on May 30 2024, 8:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 27, 7:25 AM
Unknown Object (File)
Tue, Mar 11, 1:22 AM
Unknown Object (File)
Thu, Mar 6, 1:01 PM
Unknown Object (File)
Thu, Mar 6, 1:00 PM
Unknown Object (File)
Thu, Mar 6, 1:00 PM
Unknown Object (File)
Thu, Mar 6, 1:00 PM
Unknown Object (File)
Jan 15 2025, 4:56 AM
Unknown Object (File)
Jan 12 2025, 10:28 AM
View All 73 Files
Subscribers
ashoat

Details

Reviewers
kamil
ginsu
tomek
Commits
rCOMM9b413c6fbedc: [sqlite] create message store local table
Summary

Creates a sqlite table for message store local

Depends on D12215

Test Plan

tested on native simulator. Successfully creates the sqlite table

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.May 30 2024, 8:09 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 30 2024, 8:09 AM
will edited the summary of this revision. (Show Details)May 30 2024, 8:10 AM
will added a parent revision: D12215: [lib] extend message store ops to handle processing local field ops.
will added a child revision: D12248: [sqlite] implement sqlite methods for message store local.May 30 2024, 8:12 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 30 2024, 8:21 AM
Harbormaster failed remote builds in B29304: Diff 40776!
will updated this revision to Diff 40781.May 30 2024, 9:06 AM

update wasm

Harbormaster completed remote builds in B29309: Diff 40781.May 30 2024, 9:22 AM
will requested review of this revision.May 30 2024, 9:22 AM
tomek accepted this revision.Jun 3 2024, 4:22 AM
This revision is now accepted and ready to land.Jun 3 2024, 4:22 AM
will updated this revision to Diff 41120.Jun 7 2024, 12:21 PM

rebase

will updated this revision to Diff 41121.Jun 7 2024, 12:24 PM

fix prior update

This revision was landed with ongoing or failed builds.Jun 7 2024, 12:35 PM
Closed by commit rCOMM9b413c6fbedc: [sqlite] create message store local table (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM9b413c6fbedc: [sqlite] create message store local table.
Harbormaster completed remote builds in B29537: Diff 41120.Jun 7 2024, 12:38 PM
Harbormaster completed remote builds in B29538: Diff 41121.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
17 lines
web/
shared-worker/
_generated/

Diff 40781

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Linesconst bindCallKeyserverEndpointSelector = createSelector(
( (
dispatch: Dispatch, dispatch: Dispatch,
currentUserInfo: ?CurrentUserInfo, currentUserInfo: ?CurrentUserInfo,
keyserverInfos: { +[keyserverID: string]: KeyserverInfo }, keyserverInfos: { +[keyserverID: string]: KeyserverInfo },
) => { ) => {
return _memoize( return _memoize(
<Args: $ReadOnlyArray<mixed>, Return>( <Args: $ReadOnlyArray<mixed>, Return>(
keyserverCall: KeyserverCall<Args, Return>, keyserverCall: KeyserverCall<Args, Return>,
): ((...Args) => Promise<Return>) => { ): ((...Args) => Promise<Return>) => {
michalUnsubmitted
Not Done
Inline Actions

I meant that this Return is wrong, because in case of fanout it returns [Return]

michal: I meant that this `Return` is wrong, because in case of `fanout` it returns `[Return]`
const callKeyserverEndpoint = ( const callKeyserverEndpoint = (
endpoint: Endpoint, endpoint: Endpoint,
data: Object, data: Object,
args: Args, args: Args,
options?: ?CallServerEndpointOptions, options?: ?CallServerEndpointOptions,
) => { ) => {
// TODO const bindCallKeyserverEndpoint = (keyserverID: string) => {
if (keyserverCall.config.keyserverSelection === 'fanout') {
return Promise.resolve(undefined);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
const { const {
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connection, connection,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
} = keyserverInfos[keyserverID]; } = keyserverInfos[keyserverID];
const boundCallServerEndpoint = createBoundServerCallsSelector( const boundCallServerEndpoint = createBoundServerCallsSelector(
keyserverID, keyserverID,
)({ )({
dispatch, dispatch,
currentUserInfo, currentUserInfo,
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connectionStatus: connection.status, connectionStatus: connection.status,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
}); });
return boundCallServerEndpoint(endpoint, data, options); return boundCallServerEndpoint(endpoint, data, options);
}; };
if (keyserverCall.config.keyserverSelection === 'fanout') {
const promises = [];
for (const keyserverID in keyserverInfos) {
promises.push(bindCallKeyserverEndpoint(keyserverID));
}
return Promise.all(promises);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
return bindCallKeyserverEndpoint(keyserverID);
};
return keyserverCall.actionFunc(callKeyserverEndpoint); return keyserverCall.actionFunc(callKeyserverEndpoint);
}, },
); );
}, },
); );
function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>( function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>(
Show All 21 Lines
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Linesconst bindCallKeyserverEndpointSelector = createSelector(
( (
dispatch: Dispatch, dispatch: Dispatch,
currentUserInfo: ?CurrentUserInfo, currentUserInfo: ?CurrentUserInfo,
keyserverInfos: { +[keyserverID: string]: KeyserverInfo }, keyserverInfos: { +[keyserverID: string]: KeyserverInfo },
) => { ) => {
return _memoize( return _memoize(
<Args: $ReadOnlyArray<mixed>, Return>( <Args: $ReadOnlyArray<mixed>, Return>(
keyserverCall: KeyserverCall<Args, Return>, keyserverCall: KeyserverCall<Args, Return>,
): ((...Args) => Promise<Return>) => { ): ((...Args) => Promise<Return>) => {
michalUnsubmitted
Not Done
Inline Actions

I meant that this Return is wrong, because in case of fanout it returns [Return]

michal: I meant that this `Return` is wrong, because in case of `fanout` it returns `[Return]`
const callKeyserverEndpoint = ( const callKeyserverEndpoint = (
endpoint: Endpoint, endpoint: Endpoint,
data: Object, data: Object,
args: Args, args: Args,
options?: ?CallServerEndpointOptions, options?: ?CallServerEndpointOptions,
) => { ) => {
// TODO const bindCallKeyserverEndpoint = (keyserverID: string) => {
if (keyserverCall.config.keyserverSelection === 'fanout') {
return Promise.resolve(undefined);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
const { const {
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connection, connection,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
} = keyserverInfos[keyserverID]; } = keyserverInfos[keyserverID];
const boundCallServerEndpoint = createBoundServerCallsSelector( const boundCallServerEndpoint = createBoundServerCallsSelector(
keyserverID, keyserverID,
)({ )({
dispatch, dispatch,
currentUserInfo, currentUserInfo,
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connectionStatus: connection.status, connectionStatus: connection.status,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
}); });
return boundCallServerEndpoint(endpoint, data, options); return boundCallServerEndpoint(endpoint, data, options);
}; };
if (keyserverCall.config.keyserverSelection === 'fanout') {
const promises = [];
for (const keyserverID in keyserverInfos) {
promises.push(bindCallKeyserverEndpoint(keyserverID));
}
return Promise.all(promises);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
return bindCallKeyserverEndpoint(keyserverID);
};
return keyserverCall.actionFunc(callKeyserverEndpoint); return keyserverCall.actionFunc(callKeyserverEndpoint);
}, },
); );
}, },
); );
function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>( function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>(
Show All 21 Lines