Page MenuHomePhabricator
Differential D12238

[lib][native] Move device list ops to lib
ClosedPublic
Actions

Authored by bartek on May 29 2024, 9:48 AM.
Tags
None
Referenced Files
F3371575: D12238.id40864.diff
Tue, Nov 26, 5:10 AM
F3369748: D12238.id40869.diff
Mon, Nov 25, 11:29 PM
F3368512: D12238.diff
Mon, Nov 25, 8:05 PM
Unknown Object (File)
Mon, Nov 18, 9:21 AM
Unknown Object (File)
Tue, Nov 12, 7:23 AM
Unknown Object (File)
Tue, Nov 12, 6:37 AM
Unknown Object (File)
Tue, Nov 12, 4:30 AM
Unknown Object (File)
Tue, Nov 12, 3:59 AM
View All 70 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
marcin
varun
Commits
rCOMMdcbb63430b3d: [lib][native] Move device list ops to lib
Summary

It's good to have them all in one place. In next diff I'm adding another one which is called from lib
Extracted function to fetch latest device list - it's going to be used in a lot of places.

Test Plan

Flow, ran QR auth

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.May 29 2024, 9:48 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 29 2024, 9:48 AM
bartek added a child revision: D12239: [lib] Add function to remove device from device list.May 29 2024, 9:48 AM
bartek mentioned this in D12240: [lib] Add unit tests for functions modifying device list.
Harbormaster completed remote builds in B29286: Diff 40751.May 29 2024, 10:05 AM
bartek published this revision for review.May 29 2024, 10:12 AM
bartek added reviewers: marcin, varun.Jun 3 2024, 3:51 AM
kamil accepted this revision.Jun 3 2024, 4:35 AM
kamil added inline comments.
lib/shared/device-list-utils.js
1–2 ↗(On Diff #40751)

nit: add new line here

This revision is now accepted and ready to land.Jun 3 2024, 4:35 AM
bartek updated this revision to Diff 40864.Jun 3 2024, 7:16 AM

Newline. Rebase before landing

Harbormaster completed remote builds in B29375: Diff 40864.Jun 3 2024, 7:32 AM
Closed by commit rCOMMdcbb63430b3d: [lib][native] Move device list ops to lib (authored by bartek). · Explain WhyJun 3 2024, 7:49 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMdcbb63430b3d: [lib][native] Move device list ops to lib.
bartek mentioned this in rCOMM5946d727ba67: [lib] Add unit tests for functions modifying device list.Jun 6 2024, 1:50 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
68 lines
native/
profile/
49 lines
qr-code/
33 lines

Diff 40869

View Options

lib/shared/device-list-utils.js

Loading...
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...
View Options

native/qr-code/qr-code-utils.js

Loading...